Problem adding javascript to category description

RStoelting · #1 08-23-2010, 08:13 AM

I want to add a link to a category description that will open a new window with a specific size and at the top right of the users screen. Here is the script:

Code:

<script type="text/javascript">
<!--
function popup(url) 
{
    params  =  'top=0, left=0';
    params +=  ', resizable=yes';
    params +=  ', width=620'; 
    params +=  ', height=600'; 
    params +=  ', scrollbars=1';
    params +=  ', toolbar=yes, menubar=yes';
    
    newwin=window.open(url,'windowname4', params);
    if (window.focus) {newwin.focus()}
    return false;
}
// -->
</script>

But when I add this code to the description field for "Modify Category" and save, the entire content of the description field is deleted.

Here is the code that applies the javascript to the link:

Code:

<a href="javascript: void(0)" onclick="popup('URL')">Click here</a>

Before adding the javascript code above, I was able to add this link to the category without losing the description. But of course, without the javascript code, the link did not function.

How can I add this javascript to a category?

gb2world · #2 08-23-2010, 10:15 AM

The easiest thing to do is to add it to skin1/common.js - then it will be available to any page that calls common.js - which I think may be every page on 4.1.x (if you do this, remove the <script> and </script>)

If you only want to call it on the category pages - you can add it to skin/1/customer/home.tpl with an if/than statement to only use it when you want it. If you add it to a template, be sure to surround it with {literal} and {/literal} tags.

RStoelting · #3 08-24-2010, 11:54 AM

Adding the javascript to common.js worked perfectly

Thanks for the help.

spiredem · #4 02-24-2012, 04:35 PM

Quote:

Originally Posted by RStoelting

Adding the javascript to common.js worked perfectly

Thanks for the help.

I have the same issue and wan to apply this fix. What exactly am I adding to common.js? The whole code that I'm trying to use on the page?

spiredem · #5 02-24-2012, 04:39 PM

This is my code for having an image with a mouseover area (map). Which part do I add to common.js?

Quote:

spiredem · #6 02-24-2012, 05:10 PM

ah! think i got it. thanks guys!

spiredem · #7 02-25-2012, 04:48 PM

Ok so this isn't working on this part. I put the following into skin1/common.js

Quote:

/*
This JavaScript does the work when mouse-sensitive areas are triggered.
*/
function HideDIV(d) {
document.getElementById(d).style.display = "none"; }
function DisplayDIV(d) {
document.getElementById(d).style.display = "block"; }

and here's how I call it on the page

Quote:

<span class="heroes" onmouseover="HideDIV('desc2');DisplayDIV('desc1')" )" >
brand bio
</span>

totaltec · #8 02-26-2012, 08:03 AM

When the page is loaded in the browser, is everything intact? What I mean, is all the code reaching the browser? Can you inspect element and see all your code?

spiredem · #9 02-26-2012, 08:55 AM

Yes all the code is intact on the live end. The action works when the script is on the page (offsite) but when it's only in common.js, it doesn't seem to do anything.
It worked with mouseover swap images but it's not working with swap divs.

spiredem · #10 02-26-2012, 09:16 AM

Oh this is embarrassing - I was uploading the unchanged version of common.js. Works now!