X-Cart forums

[pmdye]

As-is, that strips out way more than I think it should, to the point that it strips out the leading /xcart/, and redirects hits back to /home.html.

However, removing

$path = eregi_replace($xcart_web_dir,'',$path);

and keeping the ^ in the preg_replace_callback's seems to work just fine!

[intel352]

Originally Posted by pmdye

As-is, that strips out way more than I think it should, to the point that it strips out the leading /xcart/, and redirects hits back to /home.html.

However, removing

$path = eregi_replace($xcart_web_dir,'',$path);

and keeping the ^ in the preg_replace_callback's seems to work just fine!

well, at least part of my logic was 'sane'
glad it's working now, i'll be sure to include the working change in the next release

EDIT: please test 2 situations for me if you get a chance.
URL 1: http://www.yoursite.com/path2shop/image.php?productid=1234
URL 2: image.php?productid=1234

I'm wondering if both will be matched in the revised code, or just the 2nd url. (sorry, i'd test this myself, but the past few days I've been knee deep in another project for my company)

[jackel]

Originally Posted by intel352

Please verify that you've followed the installation steps outlined at the beginning of this thread (post 2 I believe).

Basically did everything as stated, even tried the patches for the seo mod and froogle mod, nothing seems to work.

Please advise.. also when can we expect a new version?

[intel352]

I have a higher priority project that I'm working on at the moment, I hope to be finished with it by lunchtime, which will allow me to work on XC SEO.

I will have a new version out as soon as I can get to it, hopefully today, but no promises

[eknee]

Gezzz Intel... So what you're saying is that the job you're paid for comes before this fun project that you're giving away for free...???

You're priorities are pretty messed up dude...

Thanks for all the hard work. This is definitely the best mod we've worked with (and free at that).

[intel352]

Originally Posted by eknee

Gezzz Intel... So what you're saying is that the job you're paid for comes before this fun project that you're giving away for free...???

You're priorities are pretty messed up dude...

Thanks for all the hard work. This is definitely the best mod we've worked with (and free at that).

XC SEO is actually another project for my employer, but I was given permission to give it away so that we could have testers for the project, to help us find all the issues with it

hehehe, win-win situation.

btw, I asked Qualiteam if they'd like to have the mod for incorporation into official X-Cart, in trade for a new X-Cart license, but they declined, since they just released 4.1 and cannot add new features to the package. hopefully they'll pick it up for the next release

[pmdye]

Originally Posted by intel352

well, at least part of my logic was 'sane'
glad it's working now, i'll be sure to include the working change in the next release

EDIT: please test 2 situations for me if you get a chance.
URL 1: http://www.yoursite.com/path2shop/image.php?productid=1234
URL 2: image.php?productid=1234

I'm wondering if both will be matched in the revised code, or just the 2nd url. (sorry, i'd test this myself, but the past few days I've been knee deep in another project for my company)

I can't tell for sure, since I've heavily mod'ed image.php, but testing with some other fully-qualified URL's, your're right - only the second case works.

What I have found extra is;

- The eregi_replace can go back in, but with the addition of a slash, as follows;

$path = eregi_replace($xcart_web_dir.'/','',$path);

- the regexp within the foreach further down needs a leading ^ too;

  foreach($files AS $i=>$file){
    $f1[$i] = '@^'.$file.'\.php@i';
    $f2[$i] = $file.'.html';
  }

These changes work for me, but then my skin is heavily modified, so I might be "unusual"

[intel352]

Thanks for the info Phil, I'll test your changes this afternoon. BTW, I'm glad you found the issue with the greedy regex, this project has been my first encounter with deep usage of regex, so it's been a learning process

[pmdye]

Looks like I've found another bug;

Something is interfering with XCart's normal redirection to HTTPS url's when proceeding from the cart to the checkout, if "Use HTTPS for users' login and registration" is turned on, as the subsequent checkout process remains normal HTTP.

(EDIT: "basket" means "cart" for those of us this side of the Atlantic )

[intel352]

Originally Posted by pmdye

Looks like I've found another bug;

Something is interfering with XCart's normal redirection to HTTPS url's when proceeding from the cart to the checkout, if "Use HTTPS for users' login and registration" is turned on, as the subsequent checkout process remains normal HTTP.

(EDIT: "basket" means "cart" for those of us this side of the Atlantic )

do you have more info that you can provide? i.e. - what happens to the url? what would be the normal url, and what do you get instead?

does X-Cart attempt to redirect and you get the wrong page? or does it just not redirect at all?

does it prevent you from getting to the HTTPS url completely?