X-Cart forums

[alru111]

while the mod is disabled through config.php exporting to froogle is casuing an error

Fatal error: Call to a member function on a non-object in modules/Froogle/froogle.php on line 53

[intel352]

Thanks for the bug reports guys, I'll check into it asap

[eknee]

Intel - Thanks so much for this mod, you totally rock!

I've applied it to 5 carts in the 4.0.17 - 4.0.18 range and am using it in production with no known problems.

I realize that this is for 4.0.17 and newer, but I just tried to install it on a 4.0.14 site and after installation I just got blank pages - both in the dynamic version and the HTML catalog. I've since rolled back and the site is working again. I tailed the errors log files, but there are no new entries, so I'm not sure how to troubleshoot this.

I was wondering if anyone's been successful with versions prior to 4.0.17?

Any info appreciated.

Best,
Eric

[intel352]

Originally Posted by eknee

Intel - Thanks so much for this mod, you totally rock!

I've applied it to 5 carts in the 4.0.17 - 4.0.18 range and am using it in production with no known problems.

I realize that this is for 4.0.17 and newer, but I just tried to install it on a 4.0.14 site and after installation I just got blank pages - both in the dynamic version and the HTML catalog. I've since rolled back and the site is working again. I tailed the errors log files, but there are no new entries, so I'm not sure how to troubleshoot this.

I was wondering if anyone's been successful with versions prior to 4.0.17?

Any info appreciated.

Best,
Eric

I'm glad to hear you're having success with the mod
One note, you should disable the HTML Catalog if you're running this mod, to avoid duplicate content. I've also not tested the HTML Catalog, so I'm unaware of how this mod reacts with the catalog. Once I get a chance, I'll alter XC SEO to automatically direct users away from the HTML Catalog. (Maybe give an alternative to the bot lofi mode where the HTML Catalog would be substituted as the "lofi" mode for bots)

As for older X-Cart installs, I don't have access to an older 4.0.x install, so I can't test XC SEO or troubleshoot the issues.

BTW, for error log files, make sure you check the Smarty directory as well, to see if there are errors listed there.

Out of curiousity (and to show "live" sites), would you mind posting your URLs if you use this mod? If not, I understand, not everyone wants to publicize their websites on unrelated sites

[eknee]

Thanks for the info.

A few of the sites are...

http://www.Coffee-Authority.com
http://www.Handcrafted-Replicas.com
http://www.Trollbeads-USA.com

I'll check out the smarty logs to see if I can find anything.

As far as the HTML catalog goes, it still works just fine. I'd thought to leave it there for existing links from the search engines. It doesn't seem to be a problem and I was going to leave it alone until the engines switch over to the new links.

This bring to mind a new question... We've been using Google Site Maps and I have a script that generates the links based on the HTML catalog. Any idea how to use this with XC SEO?

Thanks,
Eric

[intel352]

Thanks for the links, it's nice to see sites using the mod

In that case, leave the Catalog up. In the next release I'll make sure Catalog urls are directed to the SEO'd url, that should take care of your Google Site Maps issue (just keep generating links for google as you have been, the next release will 301 redirect those visited links to the new locations)

I intend to build in support for Google Site Maps at some point as well, fyi

[jackel]

running on a dev site at the moment ( 4.0.18 ) and this mod is not working, any help appreciated.

Mark
Jackel International Limited

[intel352]

Originally Posted by jackel

running on a dev site at the moment ( 4.0.18 ) and this mod is not working, any help appreciated.

Mark
Jackel International Limited

Please verify that you've followed the installation steps outlined at the beginning of this thread (post 2 I believe).

[pmdye]

This looks a potentially awesome mod, but I'm having trouble with the output filter munging things I don't want it to.

I've stopped it eating '@import' css tags by using the '@import url(filename.css)' notation rather than just '@import "filename.css"'.

But I'm still having trouble with it eating a <script> tag;

<script language="JavaScript" src="http://chat.kiteshop.co.uk/phplive/js/status_image.php?base_url=http://chat.kiteshop.co.uk/phplive&amp;l=pmdye&amp;x=1&amp;deptid=1&amp;btn=1" type="text/javascript"></script>

I suspect the problem lies in 'image.php' matching something it shouldn't, but don't understand the outputfilter enough to fix it...

[intel352]

Phil, you're correct, it's matching more than it should.

Try this:

Open include/class.xcart_seo.php

FIND

	function replaceUrl($uri){
		global $xcart_web_dir;

		$replacement = $uri;
		extract(parse_url($replacement));

		if($scheme!='ftp' && $scheme!='mailto' && $scheme!='javascript'){
			if($query && preg_match('@home\.php$@i',$path)){
				$gen_url = preg_replace_callback('@(.*)[&]*cat=([0-9]+)[&]*(.*)@i', array( &$this,'replaceCategoryUrl'),$query);
			}
			elseif($query && preg_match('@product\.php$@i',$path)){
				$gen_url = preg_replace_callback('@(.*)[&]*productid=([0-9]+)[&]*(.*)@i', array( &$this,'replaceProductUrl'),$query);
			}
			elseif($query && preg_match('@image\.php$@i',$path)){
				$gen_url = preg_replace_callback('@(.*)[&]*productid=([0-9]+)[&]*(.*)@i', array( &$this,'replaceImageUrl'),$query);
			}

REPLACE WITH

	function replaceUrl($uri){
		global $xcart_web_dir;

		$replacement = $uri;
		extract(parse_url($replacement));
		$path = eregi_replace($xcart_web_dir,'',$path);

		if($scheme!='ftp' && $scheme!='mailto' && $scheme!='javascript'){
			if($query && preg_match('@^home\.php$@i',$path)){
				$gen_url = preg_replace_callback('@(.*)[&]*cat=([0-9]+)[&]*(.*)@i', array( &$this,'replaceCategoryUrl'),$query);
			}
			elseif($query && preg_match('@^product\.php$@i',$path)){
				$gen_url = preg_replace_callback('@(.*)[&]*productid=([0-9]+)[&]*(.*)@i', array( &$this,'replaceProductUrl'),$query);
			}
			elseif($query && preg_match('@^image\.php$@i',$path)){
				$gen_url = preg_replace_callback('@(.*)[&]*productid=([0-9]+)[&]*(.*)@i', array( &$this,'replaceImageUrl'),$query);
			}

I haven't been able to test this yet, please let me know if this corrects the problem

Thanks