Follow us on Twitter X-Cart on Facebook Wiki
Shopping cart software Solutions for online shops and malls

X-Cart v5.3.5: Better Email Delivery, Multivendor Improvements, Orders Feed for Royal
 
Reply
   X-Cart forums > News and Announcements
 
Thread Tools
  #11  
Old 04-06-2018, 04:51 AM
  cflsystems's Avatar 
cflsystems cflsystems is offline
 

Veteran
  
Join Date: Apr 2007
Posts: 13,586
 

Default Re: X-Cart v5.3.5: Better Email Delivery, Multivendor Improvements, Orders Feed for Royal

Quote:
Originally Posted by xim
Steve, xc5 does not post filter the entered values at all. Nor for quick links, nor for the categories.

we have an improvement to replace {contact_us} with the cleanURL but not going to replace the real dynamic URL with cleanURL.

Why is that? If the page does have clean url why not use it?
So every static page has clean url. However there is no {alias} for static pages and the only safe way to refer to them as links is to use dynamic url. The system should replace these with their clean url equivalent on the fly. What's the point of having clean urls if not using them?
This means the page source code is full with dynamic urls. It is inconsistent with what the site will load
domain.com/?target=page&id=1 may convert to domain.com/this-is-you-page.html - how anyone looking at these two can make the connection?
I think any site link on any page should use the clean url if it is set, not the dynamic one.
__________________
Steve Stoyanov
CFLSystems.com
Web Development
Reply With Quote

The following user thanks cflsystems for this useful post:
kevfromwiganinlancashire (04-08-2018)
  #12  
Old 04-09-2018, 01:21 AM
 
xim xim is offline
 

X-Cart team
  
Join Date: Nov 2004
Posts: 675
 

Default Re: X-Cart v5.3.5: Better Email Delivery, Multivendor Improvements, Orders Feed for Royal

> What's the point of having clean urls if not using them?

This is the good question. Use CleanURLs links in the menu, not dynamic
__________________
Sincerely yours, Max Vydrin
Reply With Quote
  #13  
Old 04-09-2018, 05:07 AM
  cflsystems's Avatar 
cflsystems cflsystems is offline
 

Veteran
  
Join Date: Apr 2007
Posts: 13,586
 

Default Re: X-Cart v5.3.5: Better Email Delivery, Multivendor Improvements, Orders Feed for Royal

Using the dynamic url ensures the page will always work even if its clean url changes at some point.

Here is very simple example.
By default the contact page is like this - domain.com/contact_us.html
This is preset in config file (while using the underscore in the first place is a mystery to me)

If the store is started like this and links in menus use domain.com/contact_us.html and 2 months down the road it is decided to correctly rename the clean url to "contact-us" or even just "contact" the menu links will stop working. Now whoever is making the change has to know or remember to go to the menus and replace the links.

Isn't it way better if the menus use dynamic links in admin but are converted to clean urls when loading the store front? This is how it should work to begin with.
__________________
Steve Stoyanov
CFLSystems.com
Web Development
Reply With Quote
  #14  
Old 04-09-2018, 06:37 AM
 
xim xim is offline
 

X-Cart team
  
Join Date: Nov 2004
Posts: 675
 

Default Re: X-Cart v5.3.5: Better Email Delivery, Multivendor Improvements, Orders Feed for Royal

All the objects with CleanURL have a tail with 8 last defined clean URLs. So you can stay with contact_us.html in the menu, the system will redirect to the new URL automatically.

Also, when you try to enter "contact_us.html" to another page, you get the warning that this URL is already assigned to another object.

We have an improvement to make allow to choose the key pages in the menu. So, you can define the link or choose the page from the list: cart, checkout, myaccount, all static pages.
In this case, a merchant will choose the object, and the system will use the CleanURL or dynamic URL according to the settings.
__________________
Sincerely yours, Max Vydrin
Reply With Quote
  #15  
Old 06-04-2018, 11:37 AM
  cflsystems's Avatar 
cflsystems cflsystems is offline
 

Veteran
  
Join Date: Apr 2007
Posts: 13,586
 

Default Re: X-Cart v5.3.5: Better Email Delivery, Multivendor Improvements, Orders Feed for Royal

Bug report submitted for USPS module - https://bt.x-cart.com/view.php?id=49598
__________________
Steve Stoyanov
CFLSystems.com
Web Development
Reply With Quote
  #16  
Old 11-21-2018, 06:36 AM
  cflsystems's Avatar 
cflsystems cflsystems is offline
 

Veteran
  
Join Date: Apr 2007
Posts: 13,586
 

Default Re: X-Cart v5.3.5: Better Email Delivery, Multivendor Improvements, Orders Feed for Royal

Found really annoying behavior and to me this is a bug in the system.
When login in (admin or storefront) XC is searching for accounts to match the email address entered as login. If found it selects the first one.
At this stage it completely ignores everything but the email. It doesn't matter if password matches or if the login is for the admin or storefront.

This is a problem for any store upgrading from XC4 to XC5 when there are multiple accounts with same email. In XC4 you can have admin and customer accounts share the same email address/login. The check for which account to select at login is based on the area you are login into. And if there are multiple account with same email for storefront - it depends if this is anonymous account or not.
XC5 ignores all that.

Moving site from XC4 to XC5. There are 2 accounts with same email - one for admin and one for customer. The customer account has lower userid as it was created before the admin account. So when this is migrated to XC5 and you try to login to admin - guess what - XC5 finds the customer account (it is listed first as it has lower id) and of course the login to admin will fail.
This is because XC5 searches for accounts with "email", then selects the first one. Then checks if this is an admin account. Then checks if password matches...

But all these secondary checks are performed on an account which was selected solely based on email address only.

This is really not how it should be done. The conditions for the search should include "email and is admin or not (based on which area the login is for)".

While you are not allowed to create multiple accounts with same email address from admin (or as customer) going through a direct database import can lead to issues like this.

And since we do have separation of accounts roles to begin with I don't see the reason for not allowing admin and customer accounts to share email addresses. Determination of which account can login where must be done based on the role assigned to the account not by email. Otherwise the role is useless.
__________________
Steve Stoyanov
CFLSystems.com
Web Development
Reply With Quote
  #17  
Old 11-21-2018, 11:00 PM
 
xim xim is offline
 

X-Cart team
  
Join Date: Nov 2004
Posts: 675
 

Default Re: X-Cart v5.3.5: Better Email Delivery, Multivendor Improvements, Orders Feed for Royal

Steve, we do not see the reason to have admin and customer accounts for the same email and work with these accounts as separated.

Moreover, using the information that admin is surfed through customer area we can show special feature for him as "webmaster mode, in-line editing, operate as a user popup". A lot of existing customers reports us that find this feature very useful, even who also migrates from v4 to v5.

You can fix your problem very easily: just replace the email for customer profile using + sing. For example, continue using "email@domain.com" for the admin account, but replace the email of the customer account with the "email+customer@domain.com" variant.
__________________
Sincerely yours, Max Vydrin
Reply With Quote
  #18  
Old 11-21-2018, 11:22 PM
 
rodzok rodzok is offline
 

Advanced Member
  
Join Date: Apr 2008
Posts: 37
 

Default Re: X-Cart v5.3.5: Better Email Delivery, Multivendor Improvements, Orders Feed for Royal

after latest core upgrade 5.3 xcart this week my contact us page is not sending email to our mail box even though shows that message is sent on the contact page , but we do not get any emails in our mailbox and email account ( we get email from out side accounts like yahoo or gmail ) but not from contact us page any more.
server18373 dovecot: imap-login: Login: user=<helps@mezonhandbags.com>, method=PLAIN, rip=::1, lip=::1, mpid=30590, secured, session=<e564UTp74JIAAAAAAAAAAAAAAAAAAAAB>
Nov 22 00:41:32 server18373 dovecot: imap(helps@mezonhandbags.com): Logged out in=92, out=1026, bytes=92/1026
This is the error we got.
imap issue.

can some one help
__________________
2.35
Reply With Quote
  #19  
Old 11-22-2018, 02:57 AM
 
Triple A Racing Triple A Racing is offline
 

X-Adept
  
Join Date: Jul 2008
Location: Manchester UK
Posts: 777
 

Default Re: X-Cart v5.3.5: Better Email Delivery, Multivendor Improvements, Orders Feed for Royal

Quote:
Originally Posted by rodzok
after latest core upgrade 5.3 xcart this week....
If it's XC 5.3.5.7 to XC 5.3.5.8 (you didn't say in your post) then there's no change for us, post upgrade.
The Contact Us page sends e-mails, just at it did prior to the XC5 core upgrade.
The XC 5.3.5.8 Change Log only lists two small changes, so it would be unlucky, if this small core upgrade did cause that issue.
__________________
Live Store & Dev Store / XC Business 5.4.0.6 / PHP 7.3.11
Ubuntu 18.04.3 LTS (HWE 5.0.0-36.39 Kernel) / Plesk Obsidian
Nginx 1.16.1 / Apache 2.4.29 (Ubuntu Backported) / MariaDB 10.3.20
Reply With Quote
  #20  
Old 11-22-2018, 06:28 AM
  cflsystems's Avatar 
cflsystems cflsystems is offline
 

Veteran
  
Join Date: Apr 2007
Posts: 13,586
 

Default Re: X-Cart v5.3.5: Better Email Delivery, Multivendor Improvements, Orders Feed for Royal

Quote:
Originally Posted by xim
Steve, we do not see the reason to have admin and customer accounts for the same email and work with these accounts as separated.

Moreover, using the information that admin is surfed through customer area we can show special feature for him as "webmaster mode, in-line editing, operate as a user popup". A lot of existing customers reports us that find this feature very useful, even who also migrates from v4 to v5.

You can fix your problem very easily: just replace the email for customer profile using + sing. For example, continue using "email@domain.com" for the admin account, but replace the email of the customer account with the "email+customer@domain.com" variant.

I know I can fix it by changing the email. That was not the question.
The question is why when someone is trying to login XC is searching by email only disregarding the area. The login request to db is

find all records with email and give me the first one

instead of

find all records with email for zone...

The request to the db is not restrictive to the area. If it is there will be no problem having customer and admin with same email.

Anyway.
__________________
Steve Stoyanov
CFLSystems.com
Web Development
Reply With Quote
Reply
   X-Cart forums > News and Announcements


Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump


All times are GMT -8. The time now is 05:49 PM.

   

 
X-Cart forums © 2001-2018