X-Cart forums

[Loon]

We've had several problems with the regular expression that checks if the email is valid --
I changed in skin1/check_email_script.tpl and skin1/check_gcemail_script.tpl, this line:
New Code to replace old:

var goodEmail = field.value.search(/^([\w-]+(?:\.[\w-]+)*)@((?:[\w-]+\.)*\w[\w-]{0,66})\.([a-z]{2,6}(?:\.[a-z]{2})?)$/gi);

The first reiteration of this check would not allow someone with a 2 character email to register (invalid email address for ed@somewhere.net)

I tweaked it a little and then heard from a customer on RedHat Linux, Netscape 7.1, that it wouldn't allow her to register AND no error - the submit button just didn't do anything. I loaded up the browser on Fedora and sure enough, there was a javascript error. It worked fine in Netscape 7.1 on a Windows box ... weird.

Anyway, the above will allow a 1 character email name, a 1 character domain (a.com if it existed) and ed@somewhere.ca can now register.

Give yours a try on Linux with Netscape 7.1 if you can, or try to create a profile using a two character user name ... you may have the same problem.

[sanj-xcart]

Thanks for the tips.

I didn't have problems registering a 2 character email address (perhaps they have modified the regex code since 3.5), but I'm unable to check the second problem involving Netscape 7.1.

Definitely something to be aware of. Thanks.

[sunny]

Don't know if anyone monitors past threads but here goes...

I used this portion of code on a version 4.0.12 cart and while it works great - thanks so much - I wonder what all the other code in check_email_script.tpl that was replaced was doing. Was replacing all this code still the correct thing to do?

Thanks in advance.

Sunny

[jcasella]

Hi,

I know this is an old topic, but I wanted to write in to say THANK YOU to Boomer, Loon, and GM for supplying these mods with such straightforward instructions. This is a feature we've been dreaming of, and will be a huge help in accidental email address typos with our customers. More Egoods will now find their rightful owners.

Thanks again!

[eLuminateMedia]

Originally Posted by B00MER

First edit skin1/check_email_script.tpl, replace its entire contents with:

{* $Id: check_email_script.tpl,v 1.6.2.2 2004/03/26 09:47:33 svowl Exp $ *}
{literal}
<script language="JavaScript1.2">
function checkEmailAddress(field) {
 
var goodEmail = field.value.search(/^[A-Za-z0-9]{1}([A-Za-z0-9_\-\.]+)[^\.]\@[^\.]([A-Za-z0-9_\-\.]+\.)+[A-Za-z]{2,6}[ ]*$/gi);
if (goodEmail!=-1) {
    if(field.value==document.registerform.emailtwo.value) {
    return true;
  } else {
      alert("Email's do not match, please correct!");
      document.registerform.emailtwo.focus(); 
      document.registerform.emailtwo.select();
      return false;
  }
 
} else {
{/literal}
        alert("{$lng.txt_email_invalid|replace:"\n":" "|replace:"\r":" "}");
{literal}
        field.focus();
        field.select();
        return false;
    }
}
</script>
{/literal}

Now open up skin1/main/register_contact_info.tpl and underneath the email table row (</tr>) add this:

<tr valign=middle>
<td align=right>Validate {$lng.lbl_email}</td>
<td><font class=Star>*</font></td>
<td nowrap>
<input type=text name=emailtwo size=32 maxlength=128 value="{$userinfo.email}">
</td>
</tr>

This way your not inserting two emails into the database but rather making sure the user has entered the same values into the email field incase of misstypes. All javascript based.

Above code was written with 3.5.x

I can't seem to get this working any ideas what I might be doing wrong, I am quite new to Xcart but have been a web designer for some time.
I have checked a few times and seem to be following everything fine. I don't see the extra field etc.