Follow us on Twitter X-Cart on Facebook Wiki
Shopping cart software Solutions for online shops and malls

Bug in Webmaster Kit Mark Templates Function

 
Reply
   X-Cart forums > X-Cart 5 > Dev Questions (X-Cart 5)
 
Thread Tools Search this Thread
  #1  
Old 07-09-2014, 03:14 PM
  totaltec's Avatar 
totaltec totaltec is offline
 

X-Guru
  
Join Date: Jan 2007
Location: Louisville, KY USA
Posts: 5,823
 

Default Bug in Webmaster Kit Mark Templates Function

I am seeing a bug in the Webmaster Kit Module, When Solcial Login Module is enabled, Webmaster Kit no longer can Mark Templates in admin side. "Enable Tracing" dialog box does not show up unless Social Login module is disabled.

I've submitted a ticket: https://bugtracker.qtmsoft.com/view.php?id=43567
__________________
Mike White - Now Accepting new clients and projects! Work with the best, get a US based development team for just $125 an hour. Call 1-502-773-6454, email mike at babymonkeystudios.com, or skype b8bym0nkey

XcartGuru
X-cart Tutorials | X-cart 5 Tutorials

Check out the responsive template for X-cart.
Reply With Quote
  #2  
Old 07-09-2014, 07:17 PM
  totaltec's Avatar 
totaltec totaltec is offline
 

X-Guru
  
Join Date: Jan 2007
Location: Louisville, KY USA
Posts: 5,823
 

Default Re: Bug in Webmaster Kit Mark Templates Function

Nope, I was wrong, Social Login is not related. Enable Tracing dialog does not show in admin except on Installed Modules page, and Orders page. I just tricked myself thinking Social Login was related.

So every page in admin is missing the Enable Tracing dialog, except for those two sections.
__________________
Mike White - Now Accepting new clients and projects! Work with the best, get a US based development team for just $125 an hour. Call 1-502-773-6454, email mike at babymonkeystudios.com, or skype b8bym0nkey

XcartGuru
X-cart Tutorials | X-cart 5 Tutorials

Check out the responsive template for X-cart.
Reply With Quote
  #3  
Old 07-09-2014, 09:06 PM
  totaltec's Avatar 
totaltec totaltec is offline
 

X-Guru
  
Join Date: Jan 2007
Location: Louisville, KY USA
Posts: 5,823
 

Default Re: Bug in Webmaster Kit Mark Templates Function

Okay Tony, or anyone. I fixed it. But I would like to know if there is a better fix, or if there is some flaw in my logic here. Of course I am not going to modify core files, just testing this fix in the run folder.

Edit line 348 of XLite/Core/Auth.php in public function getProfile

Find:
PHP Code:
if (!$this->profile['isInitialized']) { 
Replace with:
PHP Code:
if (!$this->profile['isInitialized'] || !$this->profile['object']) { 

Is there a better way to fix this bug? Should I dig deeper?
__________________
Mike White - Now Accepting new clients and projects! Work with the best, get a US based development team for just $125 an hour. Call 1-502-773-6454, email mike at babymonkeystudios.com, or skype b8bym0nkey

XcartGuru
X-cart Tutorials | X-cart 5 Tutorials

Check out the responsive template for X-cart.
Reply With Quote
  #4  
Old 07-14-2014, 06:06 AM
  tony_sologubov's Avatar 
tony_sologubov tony_sologubov is offline
 

X-Cart team
  
Join Date: Jan 2009
Posts: 2,431
 

Default Re: Bug in Webmaster Kit Mark Templates Function

Hm, I could not recreate the problem:
http://awesomescreenshot.com/0243582t4e

Mike, can you check whether there are any error messages in var/log or in JS console, when you see this problem?

Thank you.
__________________
Found a bug in X-Cart? Post it to our bug tracker!
Know how to make X-Cart better? Suggest an idea!
Reply With Quote
  #5  
Old 07-26-2014, 07:10 PM
  totaltec's Avatar 
totaltec totaltec is offline
 

X-Guru
  
Join Date: Jan 2007
Location: Louisville, KY USA
Posts: 5,823
 

Default Re: Bug in Webmaster Kit Mark Templates Function

Tony, nothing in the log, nothing in the console.

Also it is not every page of the admin that has the issue, It appears to be just the pages where I am working, Catalog> Products> Product Details page, attributes sub page, etc.
__________________
Mike White - Now Accepting new clients and projects! Work with the best, get a US based development team for just $125 an hour. Call 1-502-773-6454, email mike at babymonkeystudios.com, or skype b8bym0nkey

XcartGuru
X-cart Tutorials | X-cart 5 Tutorials

Check out the responsive template for X-cart.
Reply With Quote
  #6  
Old 07-30-2014, 02:40 AM
  tony_sologubov's Avatar 
tony_sologubov tony_sologubov is offline
 

X-Cart team
  
Join Date: Jan 2009
Posts: 2,431
 

Default Re: Bug in Webmaster Kit Mark Templates Function

Hi Mike!

Still cannot reproduce it on 5.1.4. Could you please send me a snapshot of the problem to me?
Also, it would be helpful if you could give me an access to admin area, so I would be able to check it out there.

Tony.
__________________
Found a bug in X-Cart? Post it to our bug tracker!
Know how to make X-Cart better? Suggest an idea!
Reply With Quote

The following user thanks tony_sologubov for this useful post:
totaltec (07-30-2014)
  #7  
Old 07-30-2014, 06:57 PM
  totaltec's Avatar 
totaltec totaltec is offline
 

X-Guru
  
Join Date: Jan 2007
Location: Louisville, KY USA
Posts: 5,823
 

Default Re: Bug in Webmaster Kit Mark Templates Function

Made a video showcasing the problem: http://youtu.be/c9VHPEXW5ak

Nothing in error logs. Using 5.1.4

I'll PM you access info, its just a test store so you can play around however you like.
__________________
Mike White - Now Accepting new clients and projects! Work with the best, get a US based development team for just $125 an hour. Call 1-502-773-6454, email mike at babymonkeystudios.com, or skype b8bym0nkey

XcartGuru
X-cart Tutorials | X-cart 5 Tutorials

Check out the responsive template for X-cart.
Reply With Quote
  #8  
Old 08-01-2014, 12:51 AM
  tony_sologubov's Avatar 
tony_sologubov tony_sologubov is offline
 

X-Cart team
  
Join Date: Jan 2009
Posts: 2,431
 

Default Re: Bug in Webmaster Kit Mark Templates Function

Thank you Mike for the info!

I could see the problem and the strangest thing is that the HTML source code of almost all pages does not contain hidden info about templates as if Webmaster Kit was not enabled.

Could you please try to debug the module?

I would start with checking two things:
1) Whether the __constructStatic() method is called in the XLite/Module/XC/WebmasterKit/View/AView class
2) Whether the prepareTemplateDisplay method is called in the same class

Of course, you should debug the code in the var/run folder and you should check the code while opening pages that do not have Enable/Disable Tracing popup.

Please, let me know if you can perform this debug for me and what the results are.

Tony.
__________________
Found a bug in X-Cart? Post it to our bug tracker!
Know how to make X-Cart better? Suggest an idea!
Reply With Quote

The following user thanks tony_sologubov for this useful post:
totaltec (08-01-2014)
Reply
   X-Cart forums > X-Cart 5 > Dev Questions (X-Cart 5)


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump


All times are GMT -8. The time now is 12:02 AM.

   

 
X-Cart forums © 2001-2020