Clean urls 5.2.3

Phil Richman · #1 04-15-2015, 04:00 AM

I'm wanting to change my product clean urls. I want to use "/" instead of "html". It would be nice instead of having the locked html box at the end of the clean url line if you could just change it right there. Does anyone know how to change the extension that the cart uses for products away from the default html?

tony_sologubov · #2 04-15-2015, 06:06 AM

Could you please let me know the reason why you want your product URLs be example.com/test-product/ ? Such URLs do look like category page and it might confuse your users.

Tony

Phil Richman · #3 04-15-2015, 06:50 AM

We are bringing existing pages over from another cart and we want all of the page names to stay the same. The existing pages are already cached and well ranked with the search engines. This was easily accomplished with xcart 4 and even xcart 5.1 with some slight modifications.

Phil Richman · #4 04-15-2015, 12:15 PM

I'm trying to decorate the \XLite\Model\Repo\CleanURL class. From looking in the var/run it doesn't look my code is being included. I am adding this into my custom skin mod. My namespace is XLite\Model\Pmall\PmallSkin\Repo; and my class is class CleanURL extends \XLite\Model\Repo\CleanURL implements \XLite\Base\IDecorator

Not sure what I'm doing wrong. Any help would be greatly appreciated.

tony_sologubov · #5 04-16-2015, 04:00 AM

@Phil,

\XLite\Model\Repo\CleanURL is the right class to decorate. Basically, you need to change the value of the CLEAN_URL_DEFAULT_EXTENSION constant and change it to '' (empty line).
You would also need to change the postProcessURLProduct() method there, so it would reflect right product URL structure.

Please, let me know if it helps.

Tony

Phil Richman · #6 04-16-2015, 04:42 AM

Quote:

Originally Posted by tony_sologubov

@Phil,

\XLite\Model\Repo\CleanURL is the right class to decorate. Basically, you need to change the value of the CLEAN_URL_DEFAULT_EXTENSION constant and change it to '' (empty line).
You would also need to change the postProcessURLProduct() method there, so it would reflect right product URL structure.

Please, let me know if it helps.

Tony

Do you see a problem with my namespace? For some reason it doesn't look my code is being used. I have changed the CLEAN_URL_DEFAULT_EXTENSION constant. When I check in the var/run folder my code isn't there just the stock code.

tony_sologubov · #7 04-16-2015, 05:38 AM

Oh, yes, right.

Your namespace should be \XLite\Module\Pmall\PmallSkin\Model\Repo and the file should be located in the <X-Cart>/classes/XLite/Module/Pmall/PmallSkin/Model/Repo folder.

Phil Richman · #8 04-16-2015, 09:35 AM

Tony thanks for your help. With your suggestions I have got it to work partially, but with problems. The product shows the url with out the .html, but when you go to it you get a 404. If you want the page to show up you have to add the .html in the address bar. Honestly I think the clean urls worked better before the upgrade. I was able to get the clean urls to display the way I wanted with some minor tweaking to the /XLite/Core/Converter and the htaccess.

I would like for all the urls to appear directly from the root. For example rather than example.com/category/subcategory/product I want to see example.com/product or example.com/subcategory. Can this all be accomplished from \XLite\Model\Repo\CleanURL or do I also need to make changes to /XLite/Core/Converter.php ?

Do you have any further suggestions or advice to help me out?

tony_sologubov · #9 04-17-2015, 12:37 AM

Quote:

Originally Posted by Phil Richman

Tony thanks for your help. With your suggestions I have got it to work partially, but with problems. The product shows the url with out the .html, but when you go to it you get a 404. If you want the page to show up you have to add the .html in the address bar. Honestly I think the clean urls worked better before the upgrade. I was able to get the clean urls to display the way I wanted with some minor tweaking to the /XLite/Core/Converter and the htaccess.

Right. In case X-Cart does not recognize the clean URL as product URL, you should dig into the getTargetByCleanURL() method of \XLite object. Most likely you will need to decorate the parseCleanUrl() method of \XLite\Core\Converter class in order to overcome the problem.

Quote:

I would like for all the urls to appear directly from the root. For example rather than example.com/category/subcategory/product I want to see example.com/product or example.com/subcategory. Can this all be accomplished from \XLite\Model\Repo\CleanURL or do I also need to make changes to /XLite/Core/Converter.php ?

Do you have any further suggestions or advice to help me out?

This change is planned for the core as per discussion here:
http://forum.x-cart.com/showthread.php?p=385163#post385163

So, if you can wait, we will ship it in 5.2.5 or 5.2.6.

Phil Richman · #10 04-17-2015, 05:55 AM

Quote:

Originally Posted by tony_sologubov

Right. In case X-Cart does not recognize the clean URL as product URL, you should dig into the getTargetByCleanURL() method of \XLite object. Most likely you will need to decorate the parseCleanUrl() method of \XLite\Core\Converter class in order to overcome the problem.

This change is planned for the core as per discussion here:
http://forum.x-cart.com/showthread.php?p=385163#post385163

So, if you can wait, we will ship it in 5.2.5 or 5.2.6.

I can't seem to figure out how to decorate the parseCleanUrl method so that xcart will recognize the product urls without the html. Do you know how this needs modified to make this work?