X-Cart forums

[JeremyL]

xurunet is my account name

[intel352]

acct created, check your PM inbox. when you get a chance, might want to update the initial post (if editing is allowed) to mention the SVN location (and it has Issue tracking, which is nice)

[Jon]

Originally Posted by intel352

i dunno if you've seen how other SEO mods work for x-cart, but DSEFU for instance, had edits for every template that referenced .php urls, which was a huge amount of work. I wanted to replace everything everywhere fairly easily, so the outputfilter parses the smarty templates before the content gets sent to the browser

While this makes for less work, it should be noted that it's a huge amount of overhead, particularily with an intensive function like preg_replace, and likely will effect performance significantly.

[intel352]

and thus the reason that it's free

I've been tossing other ideas around for intercepting at a lower level to replace the URLs, but I haven't come up with anything solid yet. But as you said, performance does take a hit, so if we can't figure out a way to speed it up sufficiently, I'll probably go the DSEFU route of IF-statements in the template files (that method doesn't lend itself well to users that have a fully customized theme, though)

Alternatively, could provide a script with the mod, that would backup the user's specified theme, and then recreate the theme with all of the url structures rewritten to .html instead of .php (as needed). Then assuming we hook in to the proper areas with the mod and catch any urls that were generated dynamically by x-cart, that should remove any need for the outputfilter

we'll see, hopefully the solution will be painless

[Jon]

Yeah I understand. Just wanted users to be aware that there are positives and negatives to both approaches (edits vs. filtering) and there currently isn't an in-between

[intel352]

[Jayk]

Thanks intel352 for all of your work and JeremyL for picking up the torch.

I am looking forward to seeing install instructions for 4.1.x so that I can try this mod out. After reading through the threads, it looks very interesting.

Cheers,
Jason

[hooter]

Just to clarify, DSEFU no longer requires template edits whatsoever and hasn't for over a month now.

Kudos to the free project team though, for offering their time and expertise to the xcart community.

Originally Posted by intel352

sufficiently, I'll probably go the DSEFU route of IF-statements in the template files (that method doesn't lend itself well to users that have a fully customized theme, though)

[geckoday]

Originally Posted by Jon

While this makes for less work, it should be noted that it's a huge amount of overhead, particularily with an intensive function like preg_replace, and likely will effect performance significantly.

It actually doesn't have much of an affect on performance. I implemented a stripped down version of this mod so it works pretty similar to DSEFU. I'm now doing some profiling of X-Cart using XDebug to find where the most time is spent and I'm not seeing a noticeable difference in execution time with or without the output filter doing preg_replace on the URL's.

[intel352]

awesome, glad to see you're putting some time into testing this for us geckoday
might i ask, how many products do you have in your test store? i think with stores that have less urls to display, it's not so bad, but if you were to go to a product page that had 100+ urls, it might get a bit intensive (my employer's website has a ton of cross-referencing links over the entire site, since our site is based around music, and every CDG, Artist, and Song is a product link)

so i'll be interested to see the performance difference when used in a such an environment (i'll be testing it soon on a test version of my employer's site, haven't been able to just yet)


@hooter: glad DSEFU got rid of the template edits, that's awesome