Follow us on Twitter X-Cart on Facebook Wiki
Shopping cart software Solutions for online shops and malls

4.0.x performance improvement
 
Reply
   X-Cart forums > X-Cart 4 > Changing and adding new features
 
Thread Tools Search this Thread
  #11  
Old 09-07-2006, 11:46 PM
 
QVS QVS is offline
 

Senior Member
  
Join Date: Nov 2004
Posts: 136
 

Default Re: 4.0.x performance improvement

yep chopped a second of loading time, top stuff ...thanks
__________________
xcart version 4.1.6
UK - Brighton

QVS ELECTRICAL SUPPLIES - http://www.qvsdirect.com

We supply a huge range of cables, electrical accessories, heating, ventilation, fire and security products, consumer units & circuit distribution, indoor and outdoor lighting, showers and water heating, tools and fixings, timer switches, sockets, switches, air conditioning, trunking, and much much more.
Reply With Quote
  #12  
Old 09-08-2006, 02:44 AM
 
kenwen kenwen is offline
 

Advanced Member
  
Join Date: Jun 2006
Posts: 36
 

Default Re: 4.0.x performance improvement

call me stupid...but I can't find this file?
__________________
Ken Liu
London Kettlebells
v4.0.18
Reply With Quote
  #13  
Old 09-08-2006, 03:14 AM
  Zaja's Avatar 
Zaja Zaja is offline
 

X-Adept
  
Join Date: Mar 2004
Location: The Universe is my home
Posts: 420
 

Default Re: 4.0.x performance improvement

Quote:
Originally Posted by kenwen
...but I can't find this file?

xcart_root/include/func.php
__________________
_/ _/ _/ _/ _/ _/ _/ _/ _/

7dana.com
Reply With Quote
  #14  
Old 09-08-2006, 04:27 AM
 
balinor balinor is offline
 

Veteran
  
Join Date: Oct 2003
Location: Connecticut, USA
Posts: 30,253
 

Default Re: 4.0.x performance improvement

Wow...quite impressive! Makes you wonder how many other code blocks exist that shouldn't exist
__________________
Padraic Ryan
Ryan Design Studio
Professional E-Commerce Development
Reply With Quote
  #15  
Old 09-08-2006, 05:15 AM
 
carpeperdiem carpeperdiem is offline
 

X-Guru
  
Join Date: Jul 2006
Location: New York City, USA
Posts: 5,399
 

Default Re: 4.0.x performance improvement

Quote:
Originally Posted by balinor
Wow...quite impressive! Makes you wonder how many other code blocks exist that shouldn't exist

I would guess 20% of the code can be eliminated. That guess is not based on anything more than a hunch. Not based on scientific info, or knowledge of the codebase... I'm just picking a number out of my a$$.

I must say that I have had 3 specific instances of learning about certain code sections in x-cart that are all about supporting legacy OS configs... at the expense of security and speed.

And I'm a rookie. Imagine what a pro could find...

One thing I'm learning - there are SO MANY varieties of unix/linux and so many variations, how can a developer keep up? And versions of php and mysql - and it's more than that... within newer versions, the end user can modify the active directives and turn it into whatever they want...

So X-Cart has to over-code to consider every possible config.

In a more perfect world, X-Cart would make a version of their cart that runs a specific minimum config, and that's that...

Ralph, thanks for your contributions. Although I'm running 4.1, it's nice to know that you're hanging out.
__________________
xcart 4.5.4 gold+ w/x-payments 1.0.6; xcart gold 4.4.4
Reply With Quote
  #16  
Old 09-08-2006, 07:07 AM
 
Jerrad Jerrad is offline
 

X-Adept
  
Join Date: Nov 2004
Location: The Netherlands
Posts: 484
 

Default Re: 4.0.x performance improvement

Quote:
Originally Posted by Zaja
xcart_root/include/func.php

I have no problems finding the file, but I can't find the code that need to be deleted.
Below is my func_display from include/func.php

Code:
# # Smarty->display wrapper # function func_display($tpl, &$templater, $to_display = true) { func_get_lng_chain($tpl, $templater); if($to_display == true) { $templater->display($tpl); if(defined("START_TIME")) { global $__sql_time; $all_time = func_microtime()-START_TIME; echo '<!--<TIME all="'.$all_time.'" sql="'.$__sql_time.'" php="'.($all_time-$__sql_time).'">-->'; } } else return $templater->fetch($tpl); }
__________________
X-Cart 4.0.12
Heavy modified with paid, free and forum mods.
PHP 5.2.5 | MYSQL 5.0.51a
Reply With Quote
  #17  
Old 09-08-2006, 07:18 AM
 
geckoday geckoday is offline
 

X-Wizard
  
Join Date: Aug 2005
Posts: 1,073
 

Default Re: 4.0.x performance improvement

Quote:
Originally Posted by Jerrad
I have no problems finding the file, but I can't find the code that need to be deleted.
Below is my func_display from include/func.php

[

The code has already been removed from your func.php. Someone must have already found it and fixed it on your site.
__________________
Manuka Bay Company
X-Cart Version 4.0.19 [Linux]

UGG Boots and other fine sheepskin products
http://www.snowriver.com
Reply With Quote
  #18  
Old 09-08-2006, 07:41 AM
 
Jerrad Jerrad is offline
 

X-Adept
  
Join Date: Nov 2004
Location: The Netherlands
Posts: 484
 

Default Re: 4.0.x performance improvement

Quote:
Originally Posted by geckoday
The code has already been removed from your func.php. Someone must have already found it and fixed it on your site.

Thanks for the reply geckoday!
I just checked the original func.php from version 4.0.12 and the func_display code is exactly the same as in the func.php I'm using.

Pity, some speed improvement is always welcome.
Thanks anyway!
__________________
X-Cart 4.0.12
Heavy modified with paid, free and forum mods.
PHP 5.2.5 | MYSQL 5.0.51a
Reply With Quote
  #19  
Old 09-08-2006, 08:18 AM
 
balinor balinor is offline
 

Veteran
  
Join Date: Oct 2003
Location: Connecticut, USA
Posts: 30,253
 

Default Re: 4.0.x performance improvement

Do a search in the file, it may be in a different place
__________________
Padraic Ryan
Ryan Design Studio
Professional E-Commerce Development
Reply With Quote
  #20  
Old 09-08-2006, 08:28 AM
 
Jerrad Jerrad is offline
 

X-Adept
  
Join Date: Nov 2004
Location: The Netherlands
Posts: 484
 

Default Re: 4.0.x performance improvement

Quote:
Originally Posted by balinor
Do a search in the file, it may be in a different place

I already did and only found the func_display code in my first post.
Could it be that the func.php in version 4.0.12 is different from other 4.0.x versions?
__________________
X-Cart 4.0.12
Heavy modified with paid, free and forum mods.
PHP 5.2.5 | MYSQL 5.0.51a
Reply With Quote
Reply
   X-Cart forums > X-Cart 4 > Changing and adding new features


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump


All times are GMT -8. The time now is 03:03 PM.

   

 
X-Cart forums © 2001-2018