X-Cart forums

[Viejo]

In re feedback: I have 1.1.1 installed on two carts we are close to taking live. (4.1.3 and 4.0.19) There have been no issues at all to date. If there is a speed hit it appears to be slight. Urls work as expected. Customizations are a little tricky but we have made them to both the tpls and the root .htaccess. I'll rate the mod as top-notch and invaluable.

Intel352: Please pm me if you want to see our sites or know more about the how and why of our category handling. I don't want to hijack the thread.

[intel352]

Update: the change that is needed for include/func/func.core.php in 4.1.x, should be done in include/func.php for 4.0.x

I'm working up updating the docs

[jasonroy]

going through the install on 4.1.3 right now.

noticed this...

the doc for 1.1.1 - 1.1.5 upgrade says

-----------
Find Code:
-----------
if (!preg_match('!(\.htm(l)?|/$)!',$_tmp["path"])) {
func_header_location($l_redirect);
}
------------
Replace With
------------
################################################## ##########
# X-CART-SEO Mod :: http://code.google.com/p/x-cart-seo/
################################################## ##########
if (!empty($active_modules["XC_SEO"])) {
func_header_location($l_redirect);
}else{
if (!preg_match('!(\.htm(l)?|/$)!',$_tmp["path"])) {
func_header_location($l_redirect);
}
}
# End SEO

The only line that resembles what you've specified to find in my get_language.php file says

if (
($current_area == "C" || $current_area == "B") &&
!empty($HTTP_GET_VARS["sl"]) &&
!defined('IS_ROBOT') &&
!preg_match('/\.html?($|\?)|\/$/s', $l_redirect)
) {
func_header_location($l_redirect);
}

Either way I don't think it matters since it says its optional and I run a single language on my site.

[intel352]

Nice catch jason, I'll have to doublecheck against 4.1.3 (argh, 4.1.3 had a number of changes, lol...)

EDIT: btw, the point of that edit, is that the get_language file is NOT redirecting of the previous page had a .html extension. Which means it won't redirect back to an SEO'd url... :-\ Really I need a better workaround that what I implemented, just haven't come up with one yet

[Scott DeToffol]

I've noticed that when moving from http to https that the urls are not reformatted. Is this as designed?

[intel352]

Yes, the thought process is that search engines *shouldn't* be accessing your HTTPS site, and additionally most stores force users back to the http domain when they are wanting to browse more products. Also, wanted to avoid any unforseen issues with https urls (i.e.- in the event that a site is on shared SSL, there can be problems...)

If you would like to argue against this thought process, by all means, be my guest Additionally, if you would like to modify the code so that it functions under HTTPS, to test in your environment, let me know how it goes. I could implement an option to toggle support for rewriting under HTTPS (with an "At your own risk" disclaimer)

[Scott DeToffol]

Update: the change that is needed for include/func/func.core.php in 4.1.x, should be done in include/functions.php for 4.0.x

I don't have include/functions.php, but I do have include/func.php. I made the change there and got a SQL error:

You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'sql/xcseo.sql
sql/xcseo_lng_US.sql' at line 1
Backtrace :
/include/func.php:121
/include/func.php:80
/admin/patch_sql.php:179
/admin/patch.php:515

[Scott DeToffol]

I'm still getting Google Base/Froogle errors with the following characters:

•
’
™
®
²
½

[intel352]

I apologize, please look at the specified files:

sql/xcseo.sql
sql/xcseo_lng_US.sql

And copy the SQL commands from there. The install instructions refer to those files so that the instructions are less redundant/shorter, since the SQL is the same across 4.0.x,4.1.x

[intel352]

Regarding your Froogle errors, please refer to the Install instructions for 4.0x, scroll to the Froogle modification instructions, and make sure that your Froogle file is edited as instructed.