Follow us on Twitter X-Cart on Facebook Wiki
Shopping cart software Solutions for online shops and malls
 

X-Cart 4.7.6 released: Improved Performance, Bugfixes

 
Reply
   X-Cart forums > News and Announcements
 
Thread Tools
  #71  
Old 07-20-2016, 09:58 AM
  cflsystems's Avatar 
cflsystems cflsystems is offline
 

Veteran
  
Join Date: Apr 2007
Posts: 14,191
 

Default Re: X-Cart 4.7.6 released: Improved Performance, Bugfixes

Quote:
The aim of the variable is to run this code one time per order on the 'thank for the order' page.

Oh an by the way the part

Code:
and $main eq "order_message"

ensures it runs only on order confirmation page so there is no need to back that up with another variable
__________________
Steve Stoyanov
CFLSystems.com
Web Development
Reply With Quote
  #72  
Old 07-20-2016, 09:28 PM
 
aim aim is offline
Advanced Staff Users
 

X-Cart team
  
Join Date: Dec 2008
Posts: 928
 

Default Re: X-Cart 4.7.6 released: Improved Performance, Bugfixes

Please have a look at the screenshot
Screenshot_2016-07-21_09-25-23.png

You have to use a developer console like Firebug to check the code.

Do not use the 'View Page source' command.

Thank you.
Attached Images
File Type: png Screenshot_2016-07-21_09-25-23.png (161.9 KB, 12 views)
File Type: png Screenshot_2016-07-21_09-31-47.png (183.4 KB, 6 views)
__________________
Sincerely yours,
Ildar Amankulov
Head of Maintenance group
Reply With Quote
  #73  
Old 07-20-2016, 10:52 PM
 
Tim Soles Tim Soles is offline
 

Senior Member
  
Join Date: Sep 2006
Location: UK
Posts: 152
 

Default Re: X-Cart 4.7.6 released: Improved Performance, Bugfixes

Quote:
Originally Posted by zebu
Hi All - has anyone switched to php 7 after this upgrade? Any major issues encountered, did 3rd party mods require patches for php 7? Keen to here peoples experiences. Thanks

Our attempt to use PHP 7 failed because the third party Xbanner module does not support PHP 7 and the developer has no plans to upgrade their software.

It looks like third party modules will be a problem - see comments earlier in this thread.

Is anyone who has upgraded to 4.7.6 actually running a live site with PHP 7 ?
__________________
Version 4.7.12
Reply With Quote
  #74  
Old 07-21-2016, 05:19 AM
  cflsystems's Avatar 
cflsystems cflsystems is offline
 

Veteran
  
Join Date: Apr 2007
Posts: 14,191
 

Default Re: X-Cart 4.7.6 released: Improved Performance, Bugfixes

Quote:
Originally Posted by aim
Please have a look at the screenshot
Screenshot_2016-07-21_09-25-23.png

You have to use a developer console like Firebug to check the code.

Do not use the 'View Page source' command.

Thank you.

Of course. The developer console not the source code.
Report from the client after the change I made - sales started showing in GA.

Again I have tested this every way on different stores. Stock code is not working.
And again if the only reason for this variable is so it shows only on order confirm page there is already the "main" variable to do that
__________________
Steve Stoyanov
CFLSystems.com
Web Development
Reply With Quote
  #75  
Old 07-21-2016, 07:00 AM
 
aim aim is offline
Advanced Staff Users
 

X-Cart team
  
Join Date: Dec 2008
Posts: 928
 

Default Re: X-Cart 4.7.6 released: Improved Performance, Bugfixes

Quote:
Originally Posted by cflsystems
Of course. The developer console not the source code.
Report from the client after the change I made - sales started showing in GA.

Again I have tested this every way on different stores. Stock code is not working.
And again if the only reason for this variable is so it shows only on order confirm page there is already the "main" variable to do that

Dear Steve,

Could you check duplicated transactions on your patched stores?
For this

1)Reload the page like this 3 or more times
https://STORE_URL/cart.php?mode=order_message&orderids=1033

2)Check the number of the 1033 transactions on Google Analytics side.
Should be only one

Thank you.
__________________
Sincerely yours,
Ildar Amankulov
Head of Maintenance group
Reply With Quote
  #76  
Old 07-21-2016, 07:48 AM
  cflsystems's Avatar 
cflsystems cflsystems is offline
 

Veteran
  
Join Date: Apr 2007
Posts: 14,191
 

Default Re: X-Cart 4.7.6 released: Improved Performance, Bugfixes

That's not it. I am not sure you understand then.

With original code in template
Code:
{if $config.Google_Analytics.ganalytics_e_commerce_analysis eq "Y" and $ga_track_commerce eq "Y" and $main eq "order_message" and $orders }

the ecommerce portion does not exist on order confirmation page load and there is no ecommerce reporting in GA at all.

With this code
Code:
{if $config.Google_Analytics.ganalytics_e_commerce_analysis eq "Y" and $main eq "order_message" and $orders }

the ecommerce portion code is on the page and GA gets the data.

The $ga_track_commerce variable has a value of 'N' or it is undefined at all times. I saw all the code in the php scripts and you may think it works but it doesn't. The
Code:
x_session_register('ga_track_commerce');
line if moved from checkout_init.php to cart.php makes it work though. But it is not necessary. The $ga_track_commerce variable is useless in this case because we have in the template conditions to show the code only if the ecommerce option is enabled and page is order confirmation page and there is an order. The $ga_track_commerce variable does exactly the same as the
Code:
and $main eq "order_message"
__________________
Steve Stoyanov
CFLSystems.com
Web Development
Reply With Quote

The following user thanks cflsystems for this useful post:
aim (07-21-2016)
  #77  
Old 07-21-2016, 10:25 PM
 
aim aim is offline
Advanced Staff Users
 

X-Cart team
  
Join Date: Dec 2008
Posts: 928
 

Default Re: X-Cart 4.7.6 released: Improved Performance, Bugfixes

Thank you for the checking of the duplicated transactions.

You are right it seems GA handles the duplicated transactions properly.

I have removed the variable.


https://developers.google.com/analytics/devguides/collection/gajs/methods/gaJSApiEcommerce

_addTrans(transactionId, affiliation, total, tax, shipping, city, state, country)
Creates a transaction object with the given values. As with _addItem(), this method handles only transaction tracking and provides no additional ecommerce functionality. Therefore, if the transaction is a duplicate of an existing transaction for that session, the old transaction values are over-written with the new transaction values.



http://www.lunametrics.com/blog/2014/07/07/duplicate-transactions/

Within a session, Google Analytics will filter out duplicate transactions provided they have the same information. But if a visitor comes back later that day, or two weeks later, and another transaction is sent, then these will show up in your reports.



Thank you.
__________________
Sincerely yours,
Ildar Amankulov
Head of Maintenance group
Reply With Quote

The following user thanks aim for this useful post:
cflsystems (07-22-2016)
  #78  
Old 07-24-2016, 08:48 AM
  cflsystems's Avatar 
cflsystems cflsystems is offline
 

Veteran
  
Join Date: Apr 2007
Posts: 14,191
 

Default Re: X-Cart 4.7.6 released: Improved Performance, Bugfixes

Another bug.
4.7.6 stock cart. Place few orders. in admin select some of them and delete, confirm.
Orders do not show in admin anymore. However checking database orders info is deleted fully only from orders table.
order_details, order_status_history still have records from deleted orders

https://bt.x-cart.com/view.php?id=46315
__________________
Steve Stoyanov
CFLSystems.com
Web Development
Reply With Quote

The following user thanks cflsystems for this useful post:
aim (07-24-2016)
  #79  
Old 07-24-2016, 09:35 PM
 
aim aim is offline
Advanced Staff Users
 

X-Cart team
  
Join Date: Dec 2008
Posts: 928
 

Default Re: X-Cart 4.7.6 released: Improved Performance, Bugfixes

Quote:
Originally Posted by cflsystems
Another bug.
4.7.6 stock cart. Place few orders. in admin select some of them and delete, confirm.
Orders do not show in admin anymore. However checking database orders info is deleted fully only from orders table.
order_details, order_status_history still have records from deleted orders

https://bt.x-cart.com/view.php?id=46315

Fixed.
Thank you.
__________________
Sincerely yours,
Ildar Amankulov
Head of Maintenance group
Reply With Quote

The following 2 users thank aim for this useful post:
cflsystems (07-24-2016), herber@wirehub.nl (07-25-2016)
  #80  
Old 07-25-2016, 06:07 AM
 
herber@wirehub.nl herber@wirehub.nl is offline
 

eXpert
  
Join Date: Nov 2002
Posts: 305
 

Default Re: X-Cart 4.7.6 released: Improved Performance, Bugfixes

Great to see how fast bugs are fixed after they're reported, even though the team is probably busy as it is already!

Is 4.7.6 compatible with Google's mod_pagespeed?
Not that our website is slow, but mod_pagespeed would be a very easy way to get even more performance.
__________________
X-Cart 4.7.12
Reply With Quote
Reply
   X-Cart forums > News and Announcements



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump


All times are GMT -8. The time now is 09:01 PM.

   

 
X-Cart forums © 2001-2020