X-Cart forums

[codegrunt]

I am currently looking into migrating a number of custom modules and features from existing 4.* X-Cart installs into 5.2.

Using the Wholesale pricing module as an example, it has the following method defined:

./classes/XLite/Module/CDev/Wholesale/Model/Product.php

public function getWholesalePrice($membership)
    {
        return \XLite\Core\Database::getRepo('XLite\Module\CDev\Wholesale\Model\WholesalePrice')->getPrice(
            $this,
            $this->getWholesaleQuantity() > $this->getMinQuantity($membership) ? $this->getWholesaleQuantity() : $this->getMinQuantity($membership),
            $membership
        );
    }

I have created a second test module and within it defined the same method:

./classes/XLite/Module/MyDev/MyModule/Model/Product.php

public function getWholesalePrice($membership)
    {
    return 987654321;
  }

After redeploying the store the result from my getWholesalePrice() method from my test module is what is being called on the front end.

How does X-Cart decide which class override should be used? Is there any way to control the precedence?

Cheers,

Ron

PS: my initial post seemed to go off into the ether (silent moderation?)

[totaltec]

Originally Posted by codegrunt

PS: my initial post seemed to go off into the ether (silent moderation?)

You just needed the post to be approved because it is your first. Should be good from now on.

[cflsystems]

Originally Posted by codegrunt

How does X-Cart decide which class override should be used? Is there any way to control the precedence?

The classes are built by dev name/module alphabetically.

module/MyDev classes will be called before module/YourDev classes so YourDev will be built on top of MyDev.

To properly overwrite them you should always call parent::method first and manipulate the result the way you need it to be.

Also you should use "implements \XLite\Base\IDecorator" when extending existing classes and overwriting their methods.

If you have not seen it - .http://kb.x-cart.com/display/XDD/Developer+docs

[codegrunt]

Originally Posted by cflsystems

The classes are built by dev name/module alphabetically.

Thanks for that, at least it is predictable. X-Cart should expect a run on the Dev namespace starting with "Z".

=)

This will almost immediately be an concern for any module that needs to manipulate pricing (especially if you want a "best price" to apply) or override similar core methods that get called a lot. I don't know if there is any magic solution but I think some sort of user specified precedence would be better than hoping alphabetical works out for all cases.

[cflsystems]

Old one but I believe it is same now - https://forum.x-cart.com/showthread.php?t=69010

[qualiteam]

Yes, classes are built by dev name/module alphabetically.

Plus if you use the @LC_Dependencies tag to put your module after another one that yours depends on.