X-Cart forums

[totaltec]

Its not on for me either. Don't know what the problem is. Oh, there it goes.

[RichieRich]

it has just started

[totaltec]

I think Carrie pointed out an important subject for module developers. Other developers could easily overwrite your changes, causing a conflict. I don't know how to solve this issue, but it is important that we resolve conflicts if they do come up.

One thing that may be obvious but I wanted to mention regardless: When the cache is built, all the controllers are copied into the main controller directories. So if I have an admin controller named DropDown, and then another dev names her controller the same way, we are going to have an issue. Then there will be name-calling and finger-pointing...

Perhaps others are already doing so, but I think we should preface our controller names with our developer code. Like Controller\Admin\BCSESuperCoolMod.php.

Or is this not necessary? Is it handled some other way that I don't yet know of?

[cflsystems]

Isn't why the dev name is required and all modules by one company are hold within same main directory? With namespaces using same.
So for example

/classes/XLite/Module/CDev/GoogleAnalytics/View/Header.php

and

/classes/XLite/Module/XC/Mobile/View/Header.php

will both exists. Of course in the case of

/classes/XLite/Module/CDev/GoogleAnalytics/View/Header.php

and

/classes/XLite/Module/XXX/GoogleAnalytics/View/Header.php

one will overwrite the other but what is the point of anyone having 2 modules that do the exact same thing? You purchase and install only one of them - whichever you think is best for your store, right...

Tony - explanation?

[Ksenia]

Originally Posted by cflsystems

Tony - explanation?

Tony is about to leave for vacations. Greece, sea, sand...

Let's 'freeze' this thread till he comes back from his hot vacations and melts the 'ice'.

[totaltec]

Steve,
That is what I understood as well, the developer name would separate modules and files that were named the same. But, if you look in var/run/classes/XLite/Controller/Admin you will see all of the module controller files have been copied there. So if you write a module with a controller named Menu, and I do the same, I believe one would be overwritten or cause an error.

I guess I just need to test this theory...

[cflsystems]

Well I don't know about that, so yes probably best to test....

Oh man vacation... wish I could go... What was that again - vacation? Some sort of animal?

Have a great time Tony

[BCSE]

Steve,

If you extend a class with the idecorator interface, and it has a function called someFunction() that you want to modify, the proper way to modify it is like this:

objFunc() {
	parent::objFunc();
	.. new code here ..
}

That makes it work independently of what ever the parent class does.


But if you copy and paste the function from the parent and then modify it in your own file, that will undo any changes anyone else makes. Since you aren't extending it but replacing it.

Not sure if X-cart can do anything about it though. People just need to make sure they are coding properly.

Carrie

[cflsystems]

Yes I think this is how all the code in XC5 does it - so not to overwrite already defined things.
It does come to proper coding yes. There is nothing wrong with classes having unique prefix whether this is company name or whatever... and I for one am trying to create a pattern for CFL Systems.... besides the directory name. But at the same time you cannot re-declare functions or classes right...

[totaltec]

Originally Posted by cflsystems

Oh man vacation... wish I could go... What was that again - vacation? Some sort of animal?

I had to look that one up. Sounds like an interesting concept...

va╥ca╥tion
vāˈkāSHən,və-
noun
1. an extended period of recreation, esp. one spent away from home or in traveling.
"he took a vacation in the south of France"
synonyms: break, time off, recess, leave, leave of absence, furlough, sabbatical, spring break;

Enjoy your time off Tony, thanks for all you do.