X-Cart forums

[cherie]

There seems to be plenty of issues/fixes to warrant a prompt .1 update. Waiting until October for this critical update seems like a summer of unnecessary headaches. Too bad Classic doesn't have a cool Roadmap like Next.

[cflsystems]

Anybody else can reproduce this or is it my install - in 4.6.0 admin go to modules page and turn on or (off) any module. The top horizontal menu becomes gray, then refreshes and active again. But if you hover the Catalog menu it is missing links - depending on modules you have active you will see "extra fields", "discounts", "coupons" are not in the menu anymore. Page refresh gets them back in. I have not looked closely at the other menus

Annoying bug.

[cherie]

Yep, happens here too. An overlay gets added but never removed.

[cflsystems]

Thanks for confirming. Bug report - https://bugtracker.qtmsoft.com/view.php?id=42899

[cflsystems]

Another one, needs cleaning, it won't affect functionality. IN func.product.php function

function func_get_product_sql_orderby($orderby = '') {
    global $config, $sql_tbl;
    if (empty($orderby)) {
        $orderby = $config['Appearance']['products_order']
            ? $config['Appearance']['products_order']
            : 'orderby';
    }
    $orderby_rules = array (
        'title'       => $sql_tbl['products_lng_current'] . '.product',
        'quantity'    => $sql_tbl['products'] . '.avail',
        'orderby'     => $sql_tbl['products_categories'] . '.orderby',
        'quantity'    => $sql_tbl['products'] . '.avail',
        'price'       => 'price',
        'productcode' => $sql_tbl['products'] . '.productcode',
    );
    return isset($orderby_rules[$orderby]) ? $orderby_rules[$orderby] : $sql_tbl['products'] . '.productid';
}

repeats quantity

Also this assumes 5 ways to sort products on category/search pages while admin settings still show only 3 ways...

[carpeperdiem]

Originally Posted by cflsystems

'quantity' => $sql_tbl['products'] . '.avail',
'price' => 'price',
'productcode' => $sql_tbl['products'] . '.productcode',
);
return isset($orderby_rules[$orderby]) ? $orderby_rules[$orderby] : $sql_tbl['products'] . '.productid';
}
[/code]

repeats quantity

Steve,

This is also in 4.5.4 -- so not exclusive to 4.6.0

Are you suggesting everyone remove the duplicate

'quantity' => $sql_tbl['products'] . '.avail',

?

[cflsystems]

You can safely remove it or leave it. Since the key and the value are exactly the same for both lines in the array it will not have any effect either way. I wouldn't call it a bug.

[carpeperdiem]

Originally Posted by cflsystems

You can safely remove it or leave it. Since the key and the value are exactly the same for both lines in the array it will not have any effect either way. I wouldn't call it a bug.

For potential upgrades, best to leave it then. It would be yet one more thing to have to think about during an upgrade.

[cflsystems]

This is not only in 4.6.x but in all versions since Clean URLs were introduced in XC and it is so annoying.... (for whoever uses Clean URLs and not CDSEO). I don't know about anyone else but to me a url should be all lower cases no matter what just like the domain name. XC Clean URLs generates urls as they are typed in the product title field - so mixed lower/capital letters.

To fix this open func.clean_url.php and find

return $generated_url;

and replace it with

return strtolower($generated_url); // strtolower added to force clean url to be all lower cases - CFL Systems

I know some users like to see

http://www.domain.com/This-Is-My-Page.html

but others even try to force lowercase rewrite from htaccess to avoid changing them in XC.... This is much better

http://www.domain.com/this-is-my-page.html

[cflsystems]

Originally Posted by cherie

Yep, happens here too. An overlay gets added but never removed.

I didn't get what you were saying until I tried it on a store in development that has its customer side closed - if the store front is closed the top navigation menu becomes inaccessible after turning a module on/off until page is manually refreshed. Also

NetworkError: 503 Service Unavailable - www.domain.com/get_block.php?block=admin_menu&language=

error pops up. If store front is open this doesn't happen but the menu links are still lost.

P.S. I have similar issues with some stores using custom skins on the product details page - after "add to cart" ajax refreshes the page but instead of loading the template from the custom skin loads default XC template... This has been always a problem and the only way to fix it was to either not allow the page refresh after adding to cart or using on of the default XC skins... Very annoying and it seems to be all coming from the use of

get_block.php and func.ajax.php