X-Cart forums

[vasilis]

I have developed a module for the last minor versions of 4.4.x, 4.5.x, 4.6.x and 4.7.x branches/editions and I was wordering if I need to provide additional code for PHP incompatibilities, i.e., I have taken for granted that sites that still use X-Cart Classic, run on older PHP versions for which the X-Cart versions are compatible, so I built my module to be compatible with these PHP versions, but should I provide any coding/patches for my module to run in newer PHP versions, in case many old sites have patched their code for later PHP versions?


For example, in the File area, for the branches 4.4.x - 4.7.x, there are PHP patches for PHP 7.1 - 7.3 and a manual patch for PHP 7.4. Should I apply all these patches to each branch and check that the module will be compatible with PHP 7.4?

[Dougrun]

yes.

[vasilis]

There are 3 options to consider:


1. In case all old stores have applied the PHP 7.x patches, I should provide module code compatible with PHP 7.x from the beginning.

2. If on the other hand, not all stores have applied the PHP 7.x patches, I guess I should provide distribution packs with code compatible with the old versions of PHP that the x-cart store was compatible with, when it's version was released AND additional module patches for PHP 7.x compatibility to be applied after the module is installed, in case the store has applied the PHP patches.

3. Or, just add conditional code in the distribution packs that checks for PHP version of the running store and runs alternative code accordingly (i.e., without any patches - just the distribution pack with the conditional code).


What option would be the most realistic to follow?

[Dougrun]

2. always go with the latest code (patches included)

[thebluedoorboutique]

Agreed. I'm running 4.4.5 on PHP 8.2.