X-Cart forums

[cflsystems]

Why is Anti_Fraud module showing in admin order details even if it is off? This has been done on purpose as it wasn't like this before 4.6.0.

It shows like this

Antifraud Check Disabled Enable

QT please correct this - if anyone is interested of the module they will look for it and turn it on from admin modules, there is no need to show it like this.

It shows on order details page and also on invoice page from admin. 2 files to modify

common_-files/mail/html/order_data.tpl
common_files/main/history_order.tpl

find

{if $usertype eq "A" or $usertype eq "P"}
<br /><br /><br />
{include file="modules/Anti_Fraud/extra_data.tpl" data=$order.extra.Anti_Fraud}
{/if}

and change to

{if $active_modules.Anti_Fraud and ($usertype eq "A" or $usertype eq "P")}
<br /><br /><br />
{include file="modules/Anti_Fraud/extra_data.tpl" data=$order.extra.Anti_Fraud}
{/if}

[philrisk]

Originally Posted by ADDISON

I am not qualified to tell you what to do because my point of view must be solid based on facts/proves which I don't have.

4.6.0 is not TOTAL bug free. Qualiteam cannot prove this. Just think about Microsoft, Corel, Adobe don't say these words. Imagine for such of statement you can destroy a business.

Corel!!!! Have we jumped back to the 90's here

[carpeperdiem]

Originally Posted by ADDISON

there are two types of bugs:

In X-Cart land, there is also a 3rd kind of bug:

"product defect based on poor design choices" - but since the engineers coded X-Cart to work "perfectly" as designed, X-Cart will tell you, "it is not a bug". Examples:

- Address book
- Gift certificates
- Janrain
etc...

It's great to see the add-to-cart "upsell" design defect being addressed. Thank you!

[cflsystems]

Remember few versions ago XC had it so if there is only one language setup for a store in admin the link to admin/languages auto loads that language without having to specifically select it from the dropdown? This was active for like 1-2 releases and then magically disappear.
I would call this a bug. The code is still in the script but not being executed - there was another line of code added that prevents it from running.

In admin/languages.php

if (
    $REQUEST_METHOD == 'GET'
    && empty($mode)
    && !isset($language)
    && count($languages) == 1
) {
    // If only one language available in the store
    // then automatically select it
    func_header_location('languages.php?language=' . $current_language);
}

this is supposed to just load the language if only one is in the store. So soon after this code was added this was added before it

settype($language, 'string');

Since one of the code conditions is for $language not to be set but this one line code sets it (to either true or false) the code will not run. To fix move that line below the first block of code.

[carpeperdiem]

Originally Posted by cflsystems

Since one of the code conditions is for $language not to be set but this one line code sets it (to either true or false) the code will not run.

LO freaking L!

I routinely edit the menu item in file:

/skin/common_files/single/menu_box.tpl

FIND:

<div>
<a href="{$catalogs.admin}/languages.php">{$lng.lbl_languages}</a>

REPLACE WITH:

<div>
<a href="{$catalogs.admin}/languages.php?language=en">{$lng.lbl_languages}</a>

(that would be for english as default language)

But kinda silly since most stores admin will typically be in one language. Most... so logic says if only one language, why make users jump through any hoops? Too logical.

Thanks for finding this!
J

[cherie]

I thought they reverted to the old way since people couldn't readily find how to adjust the encoding and other general Language settings. I like the method of adding the English link to the admin menu.

[cflsystems]

Everything that is on the default page show at the end of the language page when selected so there is nothing lost or inaccessible.

[Jon]

Originally Posted by carpeperdiem

LO freaking L!

I routinely edit the menu item in file:

/skin/common_files/single/menu_box.tpl

FIND:

<div>
<a href="{$catalogs.admin}/languages.php">{$lng.lbl_languages}</a>

REPLACE WITH:

<div>
<a href="{$catalogs.admin}/languages.php?language=en">{$lng.lbl_languages}</a>

(that would be for english as default language)

But kinda silly since most stores admin will typically be in one language. Most... so logic says if only one language, why make users jump through any hoops? Too logical.

Thanks for finding this!
J

Funny to see people using the same short cuts; I do the same thing

[cflsystems]

Another bug which I suspect is present in all XC versions. Reproduced on the demo site as well

Load any page and click on login. On the login screen (or popup) click "forgot password". On that page don't do anything but click on the login link again. If popup just enter details and login. Now it is expected after login to be redirected to cart or home page or account page but no - cart stays on that same "forgot password" page which makes no sense at all.

Now if site uses https login page loads as https and forgot password as http so there will be redirect after login. But the "forgot password" page is still accessible even if logged in - http://demo.x-cart.com/demo/help.php?section=Password_Recovery - try it

What would the expected behaviour would be - if customer is logged in "forgot password" page should not be accessible. This s completely unnecessary and in case the login is in a popup can completely confuse customers why they are still on "forgot password" page

And while on the subject - why is the url still called "password recovery"? Password is not being recovered as it is not send to customers anymore instead reset password link is being send. And the page by default has the text

You can recover your lost account information using the form below. Please enter your valid email address (the one you used for registration), your account information will be mailed to you shortly.

Which is completely not what happens...

[xtech]

Hello,
What is the process of updating from 44.x Pro to 4.6.0 platinum? what is the updated patch for Pro to Platinum? Platinum file can be available only when platinum license purchased otherwise not?