X-Cart forums

[benz]

Xcart 4.1.8+ (and possibly earlier).

Possibly this should be in 3rd party mods, but this type of error will likely occur with lots of custom javascript and is really hard to track down partly due to the old style way that xcart scripts are scattered throughout the page.

If using Lytebox on your product pages and product variants you may well find that the price or stock quantity or variant images don't update when you make a new selection. This only occurs in IE (6 & 7), Firefox and Safari are fine.

The problem comes from the way Lytebox extends the array object, it adds 2 functions to the array object, which IE then includes when it iterates through the array of product variants in a "for...in.." loop, this will cause IE to crash if you try to access a property/do something on those extra functions.

To get around this you can:
a) not use (insert name of 3rd party js code here)
b) check for object types as you iterate and skip the functions added to the arrays

eg An example of this is in /modules/Product_Options/func.js
Before:

function check_options() {
    var local_taxes = [];
    var is_rebuild_wholesale = false;
    var variantid = false;

    for (var t in taxes)
        local_taxes[t] = taxes[t][0];
    price = default_price;

    /* Find variant */
    for (var x in variants) {
        if (variants[x][1].length == 0)
            continue;
        ..........

After (new code in red, green is a comment line to debug with if you use firebug's console):

function check_options() {
    var local_taxes = [];
    var is_rebuild_wholesale = false;
    var variantid = false;

    for (var t in taxes)
        local_taxes[t] = taxes[t][0];
    price = default_price;

    /* Find variant */
    for (var x in variants) {
        if (typeof(variants[x]) == "function") {
            //console.warn("In func.js, skipping: "+typeof(variants[x]))
            continue;
        }
        document.write("<Processing: "+typeof(variants[x])+"<br/>")        
        if (variants[x][1].length == 0)         
            continue;

[balinor]

Going to move this to Third Party Add-Ons, as this really isn't a bug just a compatibility issue.

[gb2world]

Hi Benz -

I don't believe you will see the issue if you apply the patch provided by QT in this thread

[geckoday]

I patched lytebox so I don't need to worry about running into this elsewhere.

In lytebox.js find this:

Array.prototype.removeDuplicates = function () { for (var i = 1; i < this.length; i++) { if (this[i][0] == this[i-1][0]) { this.splice(i,1); } } }
Array.prototype.empty = function () { for (var i = 0; i <= this.length; i++) { this.shift(); } }

And replace it with this:

function removeDuplicates(thearray) { for (var i = 1; i < thearray.length; i++) { if (thearray[i][0] == thearray[i-1][0]) { thearray.splice(i,1); } } }

Find this:

                this.frameArray.removeDuplicates();

Replace it with this:

                removeDuplicates(this.frameArray);

Find this:

                this.imageArray.removeDuplicates();

Replace it with this:

                removeDuplicates(this.imageArray);

Find this:

                this.slideArray.removeDuplicates();

Replace it with this:

                removeDuplicates(this.slideArray);

[benz]

Thanks gb2world, that patch is a bit more comprehensive!
@geckoday: nicer fix, but I think for now I'll go down the patch Xcart route rather than try to alter every single JS library/script as and when I use it

[gb2world]

right - I've run into other javascript applications besides Lytebox that need it - so QT patch is probably best. Hopefully - they will include it in 4.2. It was still is not in 4.1.11