X-Cart forums

[Sisom]

In customer/main/buy_now.tpl I found this little gem:

<div class="button-separator"></div>

only because I changed the position of the Buy Now button, so that it was on the right, not the left, and wondered why the 'Add to Wishlist' button had a space to its left, which wasn't a margin - Firebug revealed that it was A DIV!

I find this truly bizarre - that a company the size of Qualiteam, with so many talented individuals who obviously know the insides of X-Cart like the back of their hands, who can deal with the most complex server issues with no problems, haven't even got one person among them who understands the very basics of CSS - i.e. how floats work, and how margins work. Result? The entire 'CSS' version of X-Cart is a bloody mess and you will find yourselves tearing your hair out as you try to edit it all, and wonder why on earth they did it the way they did.

Sorry, I just had to vent.

[Sisom]

To which I add, from customer/main/subcategories.tpl:

{elseif !$cat_products && !$subcategories}

{$lng.txt_no_products_in_cat}

{/if}

without a paragraph element - hence there are no tags to apply CSS to!

It should be

{elseif !$cat_products && !$subcategories}

<p>  {$lng.txt_no_products_in_cat} </p>

{/if}

[inteliboy1]

True. X-Cart isn't exactly designer friendly.

I started my CSS file from scratch, and in the midst of stripping back the actual TPL files. A lot of useless garbage floating about.

Highly recommended.

I've gone from 4725 lines of CSS code - to 600. And everything in the cart is styled.


For v4.4 be good if the guys released a bare bones "framework" skin for us css/html guys.

[Sisom]

This just takes the biscuit:

<div class="creviews-vote-bar" title="Average customer rating: 5; 
Ratings: 2">
    <ul class="star-0">
  <li class="star-0">
          <span class="full">
                      </span>
              <ul class="star-1">
  <li class="star-1">
          <span class="full">
                      </span>
              <ul class="star-2">
  <li class="star-2">
          <span class="full">
                      </span>
              <ul class="star-3">
  <li class="star-3">
          <span class="full">
                      </span>
              <ul class="star-4">
  <li class="star-4">
          <span class="full">
                      </span>
          </li>
</ul>      </li>
</ul>      </li>
</ul>      </li>
</ul>      </li>
</ul>  </div>

That is just beyond belief.

[Sisom]

And there's more, from shop_closed.html:

<div id="page-container">

      <div id="header">
        <div class="line1">
            <div class="logo">
                <img src="skin1/images/xlogo.gif" alt="" />
            </div>
        </div> 
        <div class="line2">
            &nbsp;
        </div>
    </div>

    <div id="center">
        <div id="dialog-message">
            <div id="icon">
              <!--    <img src="skin1/images/lock.jpg" alt="" /> -->
            </div>
            <div id="main">
                <h1>MrDTrading is closed for maintenance.</h1>
                <p class="message">We are temporarily closed. We apologise for the inconvenience. Please check back soon.</p>
            </div>
        </div>
    </div>

    <div id="footer">
       <!--    <div class="box">
          <div class="subbox">
            <div class="left">Powered by X-Cart shopping cart software</div>
            </div>
        </div> -->
    </div><!-- END OF FOOTER -->

    </div>

I've never seen so many divs in such a short space! There just isn't any need to have so many divs, and especially so many nested divs, to display a logo, a line of text, and a heading!
I'm going to rewrite the shop_closed.html with proper CSS and post it up to completed mods when I've done so.

And I always put a comment at the end of every closing div, to explain which div it is actually closing (hence the <!-- END OF FOOTER --> in the code above.)


Edit: I have now updated a MUCH simpler shop_closed.html to Completed Mods.