Follow us on Twitter X-Cart on Facebook Wiki
Shopping cart software Solutions for online shops and malls
 

4.2 Detailed Images IE Modification Question

 
Reply
   X-Cart forums > X-Cart 4 > Dev Questions > Changing design
 
Thread Tools Search this Thread
  #1  
Old 01-22-2009, 04:25 AM
 
GreatLakesVacuum GreatLakesVacuum is offline
 

eXpert
  
Join Date: Jan 2009
Posts: 286
 

Default 4.2 Detailed Images IE Modification Question

Hello again everyone, sorry I always need so much help

LINK REMOVED BECAUSE SOME JERK FROM HERE JUST TRIED BREAKING INTO MY CURRENT LIVE STORE, I KNEW BETTER THAN TO POST LINKS!!

If you view that in Firefox, you will see I removed all the margin and padding from the detailed image thumbnails. But if you open it in IE, you will see there is some sort of padding showing up between the two horizontal rows of pictures.

Please ignore the mess that is the rest of the product description!!! I haven't fixed that yet because I needed to finish this image stuff first.

Can anyone point me to the cause of that?

I can't find anything IE specific in popup_image.tpl or main.css so far that is the cause
__________________
X-Cart 4.5.4 Gold (Live Business Site)
X-Cart 5.1.9 Business (In Development Now)
Reply With Quote
  #2  
Old 01-22-2009, 04:30 AM
 
GreatLakesVacuum GreatLakesVacuum is offline
 

eXpert
  
Join Date: Jan 2009
Posts: 286
 

Default Re: 4.2 Detailed Images IE Modification Question

Slightly more info...

main.css has this on line 3174
Code:
/* icons box */ .dpimages-icons-box { padding-top: 10px; padding-bottom: 0px; }

And it seems that IE uses the top padding (not sure about the bottom) inbetween the images as well, why? How do I stop that from happening? Plus it seems to be moving it another pixel or two more than those 10...

EDIT: only affects the top padding... I suppose I could not use the top padding and instead pad the bottom of the big product image, right?
__________________
X-Cart 4.5.4 Gold (Live Business Site)
X-Cart 5.1.9 Business (In Development Now)
Reply With Quote
  #3  
Old 01-22-2009, 04:32 AM
 
balinor balinor is offline
 

Veteran
  
Join Date: Oct 2003
Location: Connecticut, USA
Posts: 30,253
 

Default Re: 4.2 Detailed Images IE Modification Question

Make sure you look at the IE specific stylesheets as well - main.ie6.css and main.ie7.css, as well as main-popup.ie6.css

You'll quickly understand why developers HATE IE, it follows standards loosely if not at all, and you have to work around the crappy way it handles margins and padding.
__________________
Padraic Ryan
Ryan Design Studio
Professional E-Commerce Development
Reply With Quote
  #4  
Old 01-22-2009, 04:37 AM
 
GreatLakesVacuum GreatLakesVacuum is offline
 

eXpert
  
Join Date: Jan 2009
Posts: 286
 

Default Re: 4.2 Detailed Images IE Modification Question

Thanks for reminding me about those... I just checked out both the IE6 and IE7 files and none of them have anything about the detailed images stuff...

Is there something I can add there to fix this?

Yeah, IE is a bit more work, but I don't hate it (yet)
__________________
X-Cart 4.5.4 Gold (Live Business Site)
X-Cart 5.1.9 Business (In Development Now)
Reply With Quote
  #5  
Old 01-22-2009, 04:42 AM
 
GreatLakesVacuum GreatLakesVacuum is offline
 

eXpert
  
Join Date: Jan 2009
Posts: 286
 

Default Re: 4.2 Detailed Images IE Modification Question

Ok, I changed padding-top to margin-top and that solved the issue. so then I changed padding-bottom to just padding and set it specifically to 0. Now IE is only off by 1 pixel, I might just live with it.
__________________
X-Cart 4.5.4 Gold (Live Business Site)
X-Cart 5.1.9 Business (In Development Now)
Reply With Quote
  #6  
Old 01-22-2009, 04:46 AM
 
balinor balinor is offline
 

Veteran
  
Join Date: Oct 2003
Location: Connecticut, USA
Posts: 30,253
 

Default Re: 4.2 Detailed Images IE Modification Question

Search for '1px IE' on Google and you'll see a million posts - most people just live with the difference rather than to try and fix it.
__________________
Padraic Ryan
Ryan Design Studio
Professional E-Commerce Development
Reply With Quote
  #7  
Old 01-22-2009, 05:00 AM
 
GreatLakesVacuum GreatLakesVacuum is offline
 

eXpert
  
Join Date: Jan 2009
Posts: 286
 

Default Re: 4.2 Detailed Images IE Modification Question

Thanks Ryan, I think we will just live with it, its pretty good
__________________
X-Cart 4.5.4 Gold (Live Business Site)
X-Cart 5.1.9 Business (In Development Now)
Reply With Quote
Reply
   X-Cart forums > X-Cart 4 > Dev Questions > Changing design



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump


All times are GMT -8. The time now is 10:22 AM.

   

 
X-Cart forums © 2001-2020