Follow us on Twitter X-Cart on Facebook Wiki
Shopping cart software Solutions for online shops and malls
 

Image Border Editing

 
Reply
   X-Cart forums > X-Cart 4 > Dev Questions > Changing design
 
Thread Tools Search this Thread
  #1  
Old 06-13-2008, 08:43 AM
 
Aqua Aqua is offline
 

Advanced Member
  
Join Date: Feb 2007
Location: Idaho, USA
Posts: 97
 

Default Image Border Editing CSS

Hey Gurus,

While working in /skin1_c.css to change the color and weight of the product images border, I can't figure out how to make the bottom frame the same weight as the rest of the surrounding border. You'll see what I am referring to here:

http://www.aquadesign.com/Fishing-Shirts-p-1-c-250.html

Here's what my edit looks like:

.ProductBorder {
PADDING: 1px;
BACKGROUND-COLOR: #CCCCCC;
WHITE-SPACE: nowrap;
}

Any ideas what to do to fix the bottom border?

Thanks much,
__________________
Aquaman
------------------------------------
X-Cart 4.7.4 Gold
Mods:Authorize.net DPM
CDSEO, xCMS, Rich Snippets, Custom Redirects
xBanners
One Page Checkout
Magic Scroll
Google Shopping export
Lumino Responsive Template
TSS Hosting

Last edited by Aqua : 06-13-2008 at 10:03 AM. Reason: Add info to title
Reply With Quote
  #2  
Old 06-14-2008, 01:21 PM
  gb2world's Avatar 
gb2world gb2world is offline
 

X-Wizard
  
Join Date: May 2006
Location: Austin, TX
Posts: 1,970
 

Default Re: Image Border Editing

Hi Aquaman -

The border is being created not only by the padding in the .ProductBorder class - but I think also by the padding & margins of the image and even possibly the line-hight of the href inside the table cell could have an impact. And to make it more complicated - Firefox and Internet Explorer handle this a little differently - so you could make it perfect in IE and be 1px off in another browser.

That said - there are a few things you can try - you can play with the pad in .ProductBorder, maybe try padding 1px 1px 0px 1px ?

When you make the bottom 0px, and still see a border - that means there must be a pad, margin or line-height somewhere that is still causing spacing.

In Firefox - - the following seems to even out the border. If you are lucky - it will also work in IE:
padding 2px 1px 1px 1px

If none of that works - you may have to start investigating the margin/padding settings of everything inside the table cell, even the href. But know that IE and Mozilla browsers seem to handle margin/padding in table cells differently. You do have a universal selection for padding in your css * {padding:0pt;}- which should clear up some of these kinds of issues - but the margins may still be throwing things off.


Sometimes, if you want precision down to the pixel - it may be easier to just build this kind of thing in css instead of using embedded tables and fighting all the different browser ways of handling this.
__________________
X-CART (4.1.9,12/4.2.2-3/4.3.1-2/4.4.1-5)-Gold
(CDSEO, Altered-Cart On Sale, BCSE Preorder Backorder, QuickOrder, X-Payments, BCSE DPM Module)
Reply With Quote
  #3  
Old 06-17-2008, 06:39 AM
 
Aqua Aqua is offline
 

Advanced Member
  
Join Date: Feb 2007
Location: Idaho, USA
Posts: 97
 

Default Re: Image Border Editing

Thanks for your insight and ideas gb2world. It's a bit tricky when browsers display the same code differently. I appreciate your expertise on the matter.

Best regards,
__________________
Aquaman
------------------------------------
X-Cart 4.7.4 Gold
Mods:Authorize.net DPM
CDSEO, xCMS, Rich Snippets, Custom Redirects
xBanners
One Page Checkout
Magic Scroll
Google Shopping export
Lumino Responsive Template
TSS Hosting
Reply With Quote
Reply
   X-Cart forums > X-Cart 4 > Dev Questions > Changing design



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump


All times are GMT -8. The time now is 11:00 AM.

   

 
X-Cart forums © 2001-2020