X-Cart forums

[GeeCee]

I tried to install the BCSE Category Plugin from here: http://bcsengineering.com/store/customer/product.php?productid=161&cat=7&page=1

But the installation instructions appear to have caused a problem: now all product pages have the same title as their Category. This is how my home.tpl currently looks:

    <title>{strip}
    {*BCSE Begin*}
    {if $page_data.metatitle}
        {$page_data.metatitle}
    {else}
    {*BCSE End*}

        {*BCSE Begin*}
        {if $cat and $current_category.meta_title and not $smarty.get.productid}
            {$current_category.meta_title}
        {else}
        {*BCSE End*}
        
            {if $main eq "catalog" AND $current_category.categoryid eq ""}
                {$lng.txt_site_title}
            {else}
                {capture name=title}
                {if $config.SEO.page_title_format eq "A"}
                    {section name=position loop=$location}
                        {if not %position.first%}&nbsp;|&nbsp;{/if}
                        {$location[position].0|strip_tags|escape}
                    {/section}
                {else}
                    {section name=position loop=$location step=-1}
                        {if not %position.first%}&nbsp;|&nbsp;{/if}
                        {$location[position].0|strip_tags|escape}
                    {/section}
                {/if}
                {/capture}
                {if $config.SEO.page_title_limit <= 0}
                    {$smarty.capture.title}
                {else}
                    {$smarty.capture.title|replace:"&nbsp;":" "|truncate:$config.SEO.page_title_limit|replace:" ":"&nbsp;"}
                {/if}
            {/if}
        {/if}{*BCSE Added*}
    {/if}{*BCSE Added*}
    {/strip}</title>

I believe the problem is with the 2nd IF:

{if $cat and $current_category.meta_title and not $smarty.get.productid}

because if I comment this out, the product details pages show their correct title. It appears that this IF is evaluating true for product pages, and it shouldn't be, but I don't know enough about how these variables get set, to know what to change. I would hazzard a guess and say that this is the problem: and not $smarty.get.productid as it appears the intention here is to exclude product pages.

On a more general note, my <Title> is a rather confused mess now, with several different mods overlapping. Anyone got a better way of laying all this out?

Many thanks,

[balinor]

Moving to Third Party Add-Ons

[Jon]

Try:

{if $current_category.categoryid and $current_category.meta_title and not $smarty.get.productid}

[BCSE]

Originally Posted by Jon

Try:

{if $current_category.categoryid and $current_category.meta_title and not $smarty.get.productid}

Let us know if Jon's suggestion does or doesn't work! We will update the code if it does work. Possibly an incompatibility with the latest 4.1.x

Thanks,

Carrie

[Jon]

A better solution would actually be:

{if $current_category.categoryid and $current_category.meta_title and not $product.productid}

[BCSE]

Originally Posted by BCSE

Let us know if Jon's suggestion does or doesn't work! We will update the code if it does work. Possibly an incompatibility with the latest 4.1.x

Thanks,

Carrie

We've updated the code. Please use this instead:
{if $current_category.categoryid and $current_category.meta_title and not $product.productid}

This is compatible with CDSEO.

Thanks,

Carrie

[BCSE]

Ha
looks like Jon and I posted at the same time.

Our files are updated to be compatible with his CDSEO code.

Carrie

[GeeCee]

> {if $current_category.categoryid and $current_category.meta_title and not $product.productid}

That's done it, thanks for the quick turn around.

[GeeCee]

As a slight aside, the programmer in me is not liking the structure of this code now. Lots of nested IF's are never pretty, is there no SELECT CASE type structure I could use instead?

Either way, the code would be more efficient if the most commonly implemented item was the first logical step in the IF, with the least commmon condition last. Currently the tests go in this order:

- The first IF checks for static pages
- followed by category pages
- then the home page
- finally product pages.

I would have thought that testing should more correctly go in this order:

- Home page
- Category page
- Product page
- Static page

So how about something like this:

<title>{strip}
    {*CAM Check for home page*}
    {if $main eq "catalog" AND $current_category.categoryid eq ""}
        {$lng.txt_site_title}
    {else}
        {*CAM Check for Category page *}
        {if $current_category.categoryid and $current_category.meta_title and not $product.productid}
            {$current_category.meta_title}
        {else}
            {*CAM Check for Static page*}
            {if $page_data.metatitle}
                {$page_data.metatitle}
            {else}
                {*CAM Must be product page*}
                {capture name=title}
                {if $config.SEO.page_title_format eq "A"}
                    {section name=position loop=$location}
                        {if not %position.first%}&nbsp;|&nbsp;{/if}
                        {$location[position].0|strip_tags|escape}
                    {/section}
                {else}
                    {section name=position loop=$location step=-1}
                        {if not %position.first%}&nbsp;|&nbsp;{/if}
                        {$location[position].0|strip_tags|escape}
                    {/section}
                {/if}
                {/capture}
                {if $config.SEO.page_title_limit <= 0}
                    {$smarty.capture.title}
                {else}
                    {$smarty.capture.title|replace:"&nbsp;":" "|truncate:$config.SEO.page_title_limit|replace:" ":"&nbsp;"}
                {/if}
            {/if}
        {/if} 
    {/if}
{/strip}</title>

Ok that's not quite what I was hoping for as it checks for the static page before the product page.

I'm also not sure what the section that starts {if $config.SEO.page_title_limit <= 0} does, and whether that should be outside of the Product Page IF block, as currently that doesn't get run for the home page, category pages or static pages.

Sorry, I'll stop my rambling now.

[sandyscloset]

GeeCee thanks for this thread because I have been trying to figure out why my products had the category titles instead of the product titles. Fix is today.