View Single Post
  #10  
Old 03-01-2019, 03:41 AM
 
aim aim is offline
Advanced Staff Users
 

X-Cart team
  
Join Date: Dec 2008
Posts: 928
 

Default Re: PHP 5.6 and 7.0 Discontinued: How It Affects Your X-Cart 4 Store

Hello Steve,

You are right, it is safe to remove the block

PHP Code:
if (
                !empty(
$category['meta_description'])
                && !empty(
$category['meta_keywords'])
            ) {
                break;
            } 

Although I would like to keep the block for the perfomance purpose.

By the way,

I have posted a small PHP test for the function
http://codepad.org/ZVvrVbHa


PHP Code:
$category = array (
  
'meta_description' => '',
  
'meta_keywords' => 'Cube Goodies keywords',
);

if (empty(
$category['meta_description']) || empty($category['meta_keywords'])) {

        
$ids = array(5);

        
$parents =
            array (
              
=>
              array (
                
'meta_description' => 'Toys description',
                
'meta_keywords' => 'Toys keywords',
              ),
            );


        foreach (
$ids as $cid) {
            if (
                !empty(
$category['meta_description'])
                && !empty(
$category['meta_keywords'])
            ) {
                break;
            }

            
$parents[$cid]['meta_description'] = trim($parents[$cid]['meta_description']);
            
$parents[$cid]['meta_keywords'] = trim($parents[$cid]['meta_keywords']);

            if (empty(
$category['meta_description']) && !empty($parents[$cid]['meta_description']))
                
$category['meta_description'] = $parents[$cid]['meta_description'];

            if (empty(
$category['meta_keywords']) && !empty($parents[$cid]['meta_keywords']))
                
$category['meta_keywords'] = $parents[$cid]['meta_keywords'];
        }
    }

    if (
        
$category['meta_keywords'] !== 'Cube Goodies keywords'
        
|| $category['meta_description'] !== 'Toys description'
    
) {
        echo 
'TEST FAILED';
    } else {
        echo 
'TEST PASSED';
    }

    
print_r($category);die; 

Thank you.
__________________
Sincerely yours,
Ildar Amankulov
Head of Maintenance group
Reply With Quote