Has anybody done this yet via their own Custom Module and if so, how?
The original file that has to be modified is located here: /vendor/phpmailer/phpmailer/src/PHPMailer.php Not in here /skins/* and not in here /classes/Xlite/* so it's a slightly different challenge then the usual ones covered when using a Custom Module.
Currently, we copy the XC supplied core file (and retain the original) Then modify the copied file by adding in, all of the required DKIM data including the link to the correct DKIM private key located on our server. This works perfectly and all XC e-mails sent via PHPMailer are fully DKIM as a result, which is exactly what's needed.
The drag is XC upgrades. Unless the modified and original files are exchanged again, prior to an XC upgrade, the modified file is detected as part of the upgrade process. There is an option to "retain and use" it (complete with a disclaimer of how the XC upgrade may fail as a result etc
) or, overwrite the modified file with a new core file. We always exchange the files again prior to any XC upgrades, because the "retain and use option' does not work. The modified file gets overwritten regardless... So, it would be much better to use the modified core file as part of a Custom Module, which would remove the pre & post upgrade file exchange tasks. However, as detailed above, the core file has a different location than usual...
FWIW PHPMailer was upgrade to v6.0.7 in XC5.4.*. That's much better than it was in XC5.3.* but it is still some way behind the
current secure release which includes several bug fixes etc. It would be very handy if XC INCLUDE the latest PHPMailer release in XC 5.4.0.7 @mvs can you please add this to the list? It's quite a simple package replacement task for XC!
