View Single Post
  #1  
Old 10-14-2014, 02:30 PM
  cflsystems's Avatar 
cflsystems cflsystems is offline
 

Veteran
  
Join Date: Apr 2007
Posts: 14,190
 

Default XC5 uses deprecated code

Just to remind everyone about the <font> tag used in XC
http://forum.x-cart.com/showpost.php?p=371623&postcount=210

Now it seems the XC5 code also uses deprecated code. At least one place I found it

/Includes/functions.php

PHP Code:
/**
* Uploads SQL patch into the database. If $connection is not defined, uses
* mysql_query($sql) syntax, otherwise mysql_query($sql, $connection);
* If $ignoreErrors is true, it will display all SQL errors and proceed.
*/
function query_upload($filename$connection null$ignoreErrors false$is_restore false)
{
    
$fp = @fopen($filename'rb');
    if (!
$fp) {
        echo 
'<font color="red">[Failed to open $filename]</font></pre>' "\n";
        return 
false;
    } 

PHP Code:
} elseif ($table_name != "") {
                echo 
'<font color="green">[OK]</font><br />' "\n";

            } elseif (!(
$counter 20)) {
                echo 
'.';
            } 

PHP Code:
function query_upload_error($myerr$ignoreErrors)
{
    if (empty(
$myerr)) {
        echo 
"\n";
        echo 
'<font color="green">[OK]</font>' "\n";

    } elseif (
$ignoreErrors) {
        echo 
'<font color="blue">[NOTE: ' $myerr ']</font>' "\n";

    } else {
        echo 
'<font color="red">[FAILED: ' $myerr ']</font>' "\n";
    }


etc. Other files <font> tag is used:
skins/default/en/common/range_validator.tpl
skins/admin/en/shipping/charges.tpl
skins/admin/en/modules/CDev/TinyMCE/js/tinymce/plugins/bbcode/plugin.min.js
skins/admin/en/modules/CDev/TinyMCE/js/tinymce/plugins/paste/plugin.min.js

So this is XC5 which is supposed to be new modern up to date shopping cart.
Not to mention it is still using HTML4 and CSS2 (CSS3 partially as part of bootstrap I guess).
Now why is that?
__________________
Steve Stoyanov
CFLSystems.com
Web Development
Reply With Quote