Thread: 5.2.3 Invoices
View Single Post
  #9  
Old 05-10-2015, 07:22 AM
 
Triple A Racing Triple A Racing is offline
 

X-Wizard
  
Join Date: Jul 2008
Location: Manchester UK
Posts: 1,028
 

Default Re: 5.2.3 Invoices (Now 5.2.4...)

Quote:
Originally Posted by totaltec
Am I reading that you edited the core file above? What happened to only making changes via Webmaster mode.

Hahahaha Don't give birth in shock Mike, apply a little perspective here....

Yes, we only want to make changes via Webmaster mode (and have stuck to that, with this exception so far). Webmaster mode is easy (especially if you used it in 4* X-Cart previously), it works and there is NO NEED to create custom modules if you choose this option. If you recall creating a custom module resulted in a trashed upgrade from 5.1.11 to 5.2.2 for us originally... For our project, we'll avoid custom modules unless there is absolutely no other option. The only issue is when you find items that you can't access via Webmaster mode and this one ( ./skins/mail/en/common/signature.tpl file ) is an example of that. Hence the helpful, informative reply in the ticket from the X-Cart Support, which made that clear and instantly understandable.

This particular change (i.e. commenting out the 'Line') is very easy to document, record, back up (before and after) and when the next upgrade comes, yes we'll have to do it again as it will get overwritten. That's a drag, however it only takes about 50 secs once you understand it and are working from your own accurate, detailed records. We would much rather go through a simple process like that, than the dreaded #faileddeployment possibility... Also, this is a user preference and NOT a bug or fault so many people won't alter it. Even X-Cart themselves leave it in

Meanwhile, the more serious address continuity bug (it really should have been picked up before it was released) together with quite a few others that we have picked up in 5.2.4, are Core faults, so we haven't touched them at all.

We're simply waiting for the 5.2.5 epiphany - due very soon we hope!
__________________
Dev Store & Live Store XC Business 5.4.1.35
Server; Ubuntu 22.04.2 LTS (HWE 6.2.0.26.26 Kernel)) / Plesk Obsidian
Nginx 1.20.4 / Apache 2.4.52 (Ubuntu Backported) / MariaDB 10.11.4 / PHP 7.4.33
Reply With Quote