View Single Post
  #16  
Old 10-27-2012, 04:27 PM
 
carpeperdiem carpeperdiem is offline
 

X-Guru
  
Join Date: Jul 2006
Location: New York City, USA
Posts: 5,399
 

Default Re: X-Cart v4.5.4 released

Expectation: years of development should have worked its way into the core.

Disappointment: why do we have to do basic, common sense, rudimentary mods to a mature product?

For example:

Contact us form. If the cusotmer types a book (or a simple email) and uses paragraphs, xcart 4.5.4 does not preserve line breaks in the message. It's a 10-second fix, all of 7 characters, but why hasn't this been added to the core after all these years? Of course, every store has probably done this on their own, since reading an email without line breaks is next to impossible.

/include/help.php

find:
// Send mail to support

$body = $_POST['body'] = stripslashes($_POST['body']);

replace it with:
$body = $_POST['body'] = nl2br(stripslashes($_POST['body']));

uses the nl2br function of php. http://php.net/manual/en/function.nl2br.php

2 minutes of my life I'll never get back.

But why isn't this in the core? It's NOT a bug -- it's just a defect.

After sitting out many years of upgrades, I expected 4.5.4 to be a mature product. Just sharing. Remember, I love this product, but sometimes it just frustrates me.
__________________
xcart 4.5.4 gold+ w/x-payments 1.0.6; xcart gold 4.4.4