Initially, this post was about the failure of the customer address data to be consistent (in terms of display order) between the address book / entry screen and the system produced invoice. The issue that we saw was that the customer's address content MUST be consistent across ALL areas of the store (and via communications e.g. e-mail etc) unless you manually choose to alter this display / appearance / running order etc. This is surely a BASIC requirement of any software!
The "annoying marks" were an additional observation, but less important. No answers were posted on here for either (apart from your assumption of the challenge Mike, about changing the order of an array, which turns out to be correct) so we posted a ticket to the X-Cart Support Team. Here's the answers:
It appears that the address consistency failure is a core issue
So we'll need to wait until 5.2.5 for a fix as we understand this now. It is such a basic simple item and worked perfectly 20 years ago on our Window's 95 and ancient Desktop PC's! Not ideal for this to be a bug in new software releases then!
The "annoying marks" as we called them or the "Line" as it's referred to within X-Cart were implemented to "separate" the body of email from any e-mail signature. In our Linux / OS X / IOS only world, that's just bizarre but to be fair, everyone is different and uses different set-ups so at least we can see why they are (well were) there... We followed these instructions and removed them completely from our setup:
"The "---" is coded in the ./skins/mail/en/common/signature.tpl file. So, you can remove the line from the file, save it and the re-deploy the store." We did, it works, so that's fixed now.