View Single Post
  #28  
Old 06-04-2008, 06:41 AM
  Holub's Avatar 
Holub Holub is offline
 

X-Adept
  
Join Date: Jan 2008
Posts: 432
 

Default Re: [MODULE] XC SEO v1.4.0 Released for X-Cart 4.0 and 4.1

I'm sorry but seems like I've found bug in XC SEO mod:

/modules/xc_seo/outputfilter.seo.php, line 408

Code:
function _insert_href_title($found){ if( ( strpos( ' title=', $found) === false ) ){ $found = substr_replace( $found, ' title="' . str_replace( $this->_name_delim, ' ', $this->_cur_name) . '">', -1); } return $found; }

There must be strpos($found, ' title=') in condition, you are entangled haystack and needle in strpos function. This caused unnecessary second "title" attribute in

Code:
<area shape="poly" coords="424,239,509,239,509,357,424,357,424,239" href="http://www.mtechuk.com/testshop/welding-c-19.html" title="Welding" alt="Welding" title="Welding" />

After we changed haystack and needle in strpos function we got correct output HTML.
__________________
Regards,
Anthony Holub

X-Cart Skins Store
- twenty two different skins available;
- both 4.1.x and 4.2.x versions compatible;
- refresh you store now!

Smart menu X-Cart add-on
Featured Products Slide Show X-Cart add-on
"What's New?" FREE X-Cart add-on
Reply With Quote