View Single Post
  #3  
Old 02-28-2003, 12:31 AM
 
chendry chendry is offline
 

Newbie
  
Join Date: Feb 2003
Posts: 3
 

Default

Well, class names like TableTop aren't very descriptive, and class names like OrangeLine seem a bit contrary to the spirit of CSS.

As far as "How they look to you depends on what you are using to edit them." goes, i don't think any editor could make this make any sense:

Code:
{if $active_modules.Subscriptions ne "" and $products[product].catalogprice} {include file="modules/Subscriptions/subscription_info_inlist.tpl"} {else} {if $products[product].price ne 0} {if $products[product].discount ne 0} <font class=MarketPrice>{$lng.lbl_market_price}: <s> {math equation="price/(1-(discount/100))" price=$products[product].price discount=$products[product].discount format="%d.00" assign=unformatted}{include file="currency.tpl" value=$unformatted} </s></font> {/if} <font class=TableCenterProductTitleOrange>{$lng.lbl_our_price}: {include file="currency.tpl" value=$products[product].price}</font><font class=MarketPrice>{include file="customer/main/alter_currency_value.tpl" alter_currency_value=$products[product].price}</font>{if $products[product].discount ne 0}, save {$products[product].discount}%{/if}{if $config.General.use_vat eq "Y"}, including VAT {$products[product].vat}%{/if}

The lack of whitespace in that makes it hard to follow. It should look roughly like this:

Code:
{if $active_modules.Subscriptions ne "" and $products[product].catalogprice} {include file="modules/Subscriptions/subscription_info_inlist.tpl"} {else} {if $products[product].price ne 0} {if $products[product].discount ne 0} <font class=MarketPrice>{$lng.lbl_market_price}: <s> {math equation="price/(1-(discount/100))" price=$products[product].price discount=$products[product].discount format="%d.00" assign=unformatted} {include file="currency.tpl" value=$unformatted} </s> </font> {/if} <font class=TableCenterProductTitleOrange> {$lng.lbl_our_price}: {include file="currency.tpl" value=$products[product].price} </font> <font class=MarketPrice> {include file="customer/main/alter_currency_value.tpl" alter_currency_value=$products[product].price} </font> {if $products[product].discount ne 0}, save {$products[product].discount}%{/if} {if $config.General.use_vat eq "Y"}, including VAT {$products[product].vat}%{/if}

I may have made a mistake or two in there, but you get the idea. Also, in the above example, a couple Smarty {strip} tags would get rid of any excess whitespace that would screw up the browser.

But, I guess, most of that is cosmetic and not terribly important on my end. What is a show-stopper here, however, is that several templates are shared between the administration and the customer interfaces. It's more-or-less impossible with the existing set of templates to give the administration interface a separate look-and-feel from the customer interface. Maybe I am wrong here? Do you have any tips?

Would any of you benefit from templates that make it easy to nail down the LAF of your administration interface, and vary the customer LAF independently? I think this would be the best way because some customer LAFs make for lousy administration LAFs. Also, what about ISPs and whatnot who want to brand their administration LAF?

What do you all think about this?

- chad
Reply With Quote