View Single Post
  #5  
Old 07-23-2010, 04:07 PM
 
Sisom Sisom is offline
 

eXpert
  
Join Date: Sep 2006
Posts: 310
 

Default Re: Now I know Qualiteam don't understand basic CSS...

And there's more, from shop_closed.html:


Code:
<div id="page-container"> <div id="header"> <div class="line1"> <div class="logo"> <img src="skin1/images/xlogo.gif" alt="" /> </div> </div> <div class="line2"> &nbsp; </div> </div> <div id="center"> <div id="dialog-message"> <div id="icon"> <!-- <img src="skin1/images/lock.jpg" alt="" /> --> </div> <div id="main"> <h1>MrDTrading is closed for maintenance.</h1> <p class="message">We are temporarily closed. We apologise for the inconvenience. Please check back soon.</p> </div> </div> </div> <div id="footer"> <!-- <div class="box"> <div class="subbox"> <div class="left">Powered by X-Cart shopping cart software</div> </div> </div> --> </div><!-- END OF FOOTER --> </div>


I've never seen so many divs in such a short space! There just isn't any need to have so many divs, and especially so many nested divs, to display a logo, a line of text, and a heading!
I'm going to rewrite the shop_closed.html with proper CSS and post it up to completed mods when I've done so.

And I always put a comment at the end of every closing div, to explain which div it is actually closing (hence the <!-- END OF FOOTER --> in the code above.)


Edit: I have now updated a MUCH simpler shop_closed.html to Completed Mods.
__________________
X-Cart Gold Version 4.3.2
Reply With Quote