View Single Post
  #367  
Old 12-12-2007, 12:51 PM
 
cbarnes cbarnes is offline
 

Member
  
Join Date: Oct 2005
Location: Kansas
Posts: 18
 

Default Re: XC SEO v1.1.0 Released

I believe I may have found a small bug with XC SEO v1.2.0

I was checking my client's site to be sure that the xHTML was valid and I was getting a bunch of these errors...

duplicate specification of attribute "title"

So, I dove into the code and there is a function that looks for the "title" attribute and if it is not found, it adds the title attribute to the a href tag.

However, it never finds title attributes that are already there.

So, I changed this function and It appears to be working for me...

In the file outputfilter.seo.php, I changed this...

PHP Code:
function _insert_href_title($found){
    if((
strpos(" title=",$found)===false)){
        
$found substr_replace($found,' title="'.str_replace($this->_name_delim,' ',$this->_cur_name).'">',-1);
    }
    return 
$found;


to this...

PHP Code:
function _insert_href_title($found){
    if((
eregi("title=",$found)===false)){
        
$found substr_replace($found,' title="'.str_replace($this->_name_delim,' ',$this->_cur_name).'">',-1);
    }
    return 
$found;


I hope this helps.
__________________
Chris Barnes
Ative LLC
X-Cart Development & Consulting
Reply With Quote