Image broke on my upgrade test installation (direct copy of my current version). Going to give this a try
(will post back with results).
EDIT: What I did was create a duplicate of my original x-cart installation and MySQL DB. Then I put it in a subdirectory and created another DB. This second set of DB / web content is pretty much the same with the only difference being in config.php and that I upgraded it from v4.0.18 to v4.0.19. The images are of course broken and at first I thought that would be natural but these images have full path to the image location and the images at the original location are still there (there's even a copy of those images in the copy installation as well).
Now why would the images break still?
EDIT: Just ran a test.
Let's say :
Originally I had : /usr/home/xcart/images/abc123.gif (same as in my copy installation) in the DB (images stored in FS)
However, the copy installation will not display the images. So I change it to : /usr/home/xcart/upgraded/images/abc123.gif and magically it works.
My conclusion is that X-Cart appends something that makes it fail to reach the image even though it asked for a full path. Still doesn't explain a whole lot.
EDIT: Not being all that familiar with regular expressions. Let's say I moved it into a sub-directory.
From /usr/home/xcart/
To /usr/home/xcart/upgraded/
I should have:
$pattern = "\/xcart";
$replace = "/xcart/upgraded";
Is that assumption correct?