X-Cart forums - 4.2 User Name Question

X-Cart forums (https://forum.x-cart.com/index.php)

- Changing design (https://forum.x-cart.com/forumdisplay.php?f=51)

- - 4.2 User Name Question (https://forum.x-cart.com/showthread.php?t=43860)

4.2 User Name Question

Please move this message if I posted to wrong forum.

I am trying to change the registration form to allow capital letters. I changed the following line in include/register.php but it does not work.

From:
if ((strcmp($uname_tmp, $uname) != 0) || (!preg_match("/^[a-z0-9_-]+$/s", $uname) && $uname != ""))

To:
if ((strcmp($uname_tmp, $uname) != 0) || (!preg_match("/^[a-zA-Z0-9_-]+$/s", $uname) && $uname != ""))

when registering an admin or customer, it still displays the error message that only lower case letters and numbers may be used.

Re: 4.2 User Name Question

Did you clear the cache?

Strange how in prior versions x-cart used "!preg_match", but in 4.1.11 they used "eregi", and now with 4.2 it looks like they are going back to "!preg_match".

Why would they do that?

Re: 4.2 User Name Question

Yes I cleared the the templates_c folder and I cleared my browser cache. I even tried a different browser.

Re: 4.2 User Name Question

I got it to save the profile, but when it saves it to the database even though there are capital letters, it saves it in the database as lower case letters.

There is something over riding the settings on the register.php file.

Re: 4.2 User Name Question

Strange...
In 4.1.8 (note: no "!preg_match" or "eregi")

Code:

        #

        # Check for errors

        #

        $uname_tmp=stripslashes($uname);

        if (strcmp($uname_tmp, $uname) !=0)

                $error="Username ".$uname_tmp." is invalid! Please correct";

        else

                $error='';



        $smarty->assign("error",$error);

In 4.1.10 (added "eregi" and "newbie/anonymous" checks)

Code:

        #

        # Check for errors

        #

        $uname_tmp=stripslashes($uname);

        if ((strcmp($uname_tmp, $uname) !=0) || (eregi("[^a-z0-9_-]",$uname) && $newbie == "Y" && $anonymous != "Y"))

                $error="username";

        else

                $error='';



        $smarty->assign("error",$error);

In Security Patch 2008-07-02_4.1.10 (no change from 4.1.10 - still "eregi"and "newbie/anonymous" checks)

Code:

        #

        # Check for errors

        #

        $uname_tmp=stripslashes($uname);

        if ((strcmp($uname_tmp, $uname) !=0) || (eregi("[^a-z0-9_-]",$uname) && $newbie == "Y" && $anonymous != "Y"))

                $error="username";

        else

                $error='';



        $smarty->assign("error",$error);

In 4.1.11 (changed "eregi" to "!preg_match"and no "newbie/anonymous" checks)

Code:

        #

        # Check for errors

        #

        $error = '';



        # Login will be checked only for new profiles

        if ($mode != "update") { 

                $uname_tmp = stripslashes($uname);

                if ((strcmp($uname_tmp, $uname) != 0) || (!preg_match("/^[a-z0-9_-]+$/s", $uname) && $uname != "")) 

                        $error = "username";

        }                



        $smarty->assign("error", $error);

In 4.2.0b (no change from 4.1.11)

Code:

        #

        # Check for errors

        #

        $error = '';



        # Login will be checked only for new profiles

        if ($mode != "update") { 

                $uname_tmp = stripslashes($uname);

                if ((strcmp($uname_tmp, $uname) != 0) || (!preg_match("/^[a-z0-9_-]+$/s", $uname) && $uname != "")) 

                        $error = "username";

        }                



        $smarty->assign("error", $error);

This brings some questions...
1. Why the switch from "eregi" to "!preg_match"?
2 Why were the "newbie" and "anonymous" checks added, then removed?
3. Why was "if ($mode != "update")" added if, as you say, "There is something over riding the settings" when it is updated?

Re: 4.2 User Name Question

I have been looking for this for days,

The user name will save as capital letters, but when it shows who is logged in it shows all lower case letters.

I have searched through the mysql data base and have not found any other places where the customer user name is saved. So it must be some code somewhere that is causing the names to display in lower case only.

Re: 4.2 User Name Question

Have you checked the templates to see if it's using something like {$username|lower} ?