X-Cart: shopping cart software

X-Cart forums (https://forum.x-cart.com/index.php)
-   News and Announcements (https://forum.x-cart.com/forumdisplay.php?f=28)
-   -   Pop-up Anywhere module released (https://forum.x-cart.com/showthread.php?t=66512)

Kman 11-13-2014 02:33 PM

Re: Pop-up Anywhere module released
 
We've used this module at times, and have it wired as far as the functionality is concerned. Very useful. But . . .

In modules/Popup_Anwhere/js/popups.js there is this code:

window.fbAsyncInit = function() {
FB.init({
status: true, // check login status
cookie: true, // enable cookies to allow the server to access the session
xfbml: true // parse XFBML
});
};

(function(d){
var js, id = 'facebook-jssdk'; if (d.getElementById(id)) {return;}
js = d.createElement('script'); js.id = id; js.async = true;
var host = document.location.protocol == "https:" ? "https:" : "http:";
js.src = host + "//connect.facebook.net/en_US/all.js";
d.getElementsByTagName('head')[0].appendChild(js);
}(document));


which among other things loads Facebook's all.js

With this loaded, these browser warnings occur:

Invalid App Id: Must be a number or numeric string representing the application id. all.js:58
The "fb-root" div has not been created, auto-creating all.js:58
FB.getLoginStatus() called before calling FB.init().


A little research shows that this is an error that may trigger when FB.init is not called before FB.login, which is not the case here.

Since we have not changed any of the basic templates or js files, I have to assume that we are not the only ones who have this issue.

Qualiteam - what's up with this?

vladimir.gritsenko 11-14-2014 12:58 AM

Re: Pop-up Anywhere module released
 
Quote:

Originally Posted by Kman
We've used this module at times, and have it wired as far as the functionality is concerned. Very useful. But . . .
...

Qualiteam - what's up with this?


Hi, Kman!

Thanks for the report. I doubt it's related to Popup anywhere though. You may find the very same warning at Home page of X-Cart demo: http://demo.x-cart.com/demo/home.php There is no Pop-up anywhere enabled.

As I understand, this is a FB side issue.

Thank you.

Kman 11-14-2014 01:40 PM

Re: Pop-up Anywhere module released
 
The relationship is this - the offending facebook js is called by the Popup Anywhere file, popups.js. Toggle off this module and the errors vanish.

It may just be one of those issues for which there is no good solution.

vladimir.gritsenko 11-16-2014 09:17 PM

Re: Pop-up Anywhere module released
 
Quote:

Originally Posted by Kman
The relationship is this - the offending facebook js is called by the Popup Anywhere file, popups.js. Toggle off this module and the errors vanish.

It may just be one of those issues for which there is no good solution.


Indeed, the module calls the FB js library but like you said, there's hardly something to be done at our side. Nevertheless, I passed it to our architects for review. I doubt they'll give this warning high priority but still.

Thank you for report.

masada3336 12-13-2014 11:42 AM

Re: Pop-up Anywhere module released
 
Has anyone had issues on IE with this? The popup appears on EVERY page, EVERY time - no matter if you're signed up or you "x" our of it, or you say, "no thanks" - it's persistent on every page load with IE

totaltec 12-13-2014 09:49 PM

Re: Pop-up Anywhere module released
 
Quote:

Originally Posted by masada3336
Has anyone had issues on IE with this? The popup appears on EVERY page, EVERY time - no matter if you're signed up or you "x" our of it, or you say, "no thanks" - it's persistent on every page load with IE

Are you allowing cookies with IE? Have you tried from another computer?

masada3336 12-14-2014 09:54 AM

Re: Pop-up Anywhere module released
 
Yep...lots of customers complained, I tested it, and had a few other people test it.

shwekhaw 12-25-2014 07:49 AM

Re: Pop-up Anywhere module released
 
Quote:

Originally Posted by masada3336
Has anyone had issues on IE with this? The popup appears on EVERY page, EVERY time - no matter if you're signed up or you "x" our of it, or you say, "no thanks" - it's persistent on every page load with IE


Have you tried upgrading the popup Anywhere module? QT released new version back Aug 2014 for 4.4.5. Check your current file date to see if you have older version. I was having some php errors in func.php and just checked the to see if there is new version. I found newer version released in Dec 2 2014. I just updated mine and php errors are gone.

I think QT should email out every customer who bought the module when a module got updated, especially if the update includes fixing a bug.

BBM_ 03-18-2015 08:47 PM

Re: Pop-up Anywhere module released
 
Can anyone please provide some assistance on the below?

I have this module integrated into a custom skin (4.4.4 store) and all appears to work correctly except that the pop-up position is always at the top of the screen.

Edit: It's a jquery conflict that causes the above.

BBM_ 04-08-2015 02:41 AM

Re: Pop-up Anywhere module released
 
I just wanted to see does anyone use this module with CDSEO PRO as the feature to make popups only appear on specific pages does not work in conjunction with the urls being rewritten by CDSEO pro.

Thanks in advance


All times are GMT -8. The time now is 09:07 AM.

Powered by vBulletin Version 3.5.4
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.