Bug in Webmaster Kit Mark Templates Function
I am seeing a bug in the Webmaster Kit Module, When Solcial Login Module is enabled, Webmaster Kit no longer can Mark Templates in admin side. "Enable Tracing" dialog box does not show up unless Social Login module is disabled.
I've submitted a ticket: https://bugtracker.qtmsoft.com/view.php?id=43567 |
Re: Bug in Webmaster Kit Mark Templates Function
Nope, I was wrong, Social Login is not related. Enable Tracing dialog does not show in admin except on Installed Modules page, and Orders page. I just tricked myself thinking Social Login was related. :-)
So every page in admin is missing the Enable Tracing dialog, except for those two sections. |
Re: Bug in Webmaster Kit Mark Templates Function
Okay Tony, or anyone. I fixed it. But I would like to know if there is a better fix, or if there is some flaw in my logic here. Of course I am not going to modify core files, just testing this fix in the run folder.
Edit line 348 of XLite/Core/Auth.php in public function getProfile Find: PHP Code:
PHP Code:
Is there a better way to fix this bug? Should I dig deeper? |
Re: Bug in Webmaster Kit Mark Templates Function
Hm, I could not recreate the problem:
http://awesomescreenshot.com/0243582t4e Mike, can you check whether there are any error messages in var/log or in JS console, when you see this problem? Thank you. |
Re: Bug in Webmaster Kit Mark Templates Function
Tony, nothing in the log, nothing in the console.
Also it is not every page of the admin that has the issue, It appears to be just the pages where I am working, Catalog> Products> Product Details page, attributes sub page, etc. |
Re: Bug in Webmaster Kit Mark Templates Function
Hi Mike!
Still cannot reproduce it on 5.1.4. Could you please send me a snapshot of the problem to me? Also, it would be helpful if you could give me an access to admin area, so I would be able to check it out there. Tony. |
Re: Bug in Webmaster Kit Mark Templates Function
Made a video showcasing the problem: http://youtu.be/c9VHPEXW5ak
Nothing in error logs. Using 5.1.4 I'll PM you access info, its just a test store so you can play around however you like. |
Re: Bug in Webmaster Kit Mark Templates Function
Thank you Mike for the info!
I could see the problem and the strangest thing is that the HTML source code of almost all pages does not contain hidden info about templates as if Webmaster Kit was not enabled. Could you please try to debug the module? I would start with checking two things: 1) Whether the __constructStatic() method is called in the XLite/Module/XC/WebmasterKit/View/AView class 2) Whether the prepareTemplateDisplay method is called in the same class Of course, you should debug the code in the var/run folder and you should check the code while opening pages that do not have Enable/Disable Tracing popup. Please, let me know if you can perform this debug for me and what the results are. Tony. |
All times are GMT -8. The time now is 04:36 AM. |
Powered by vBulletin Version 3.5.4
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.