X-Cart: shopping cart software

X-Cart forums (https://forum.x-cart.com/index.php)
-   Dev Questions (X-Cart 5) (https://forum.x-cart.com/forumdisplay.php?f=56)
-   -   SimpleCMS module - site logo (https://forum.x-cart.com/showthread.php?t=75529)

cflsystems 07-23-2017 10:38 AM

SimpleCMS module - site logo
 
Just a warning for everyone relying on SimpleCMS module to change their site logo.

The module is coded so to change the image name you are uploading as logo and Apple icon.

It will prepend "logo_" and "appleIcon_" to the uploaded image name.

So if you are uploading site logo as "my-site-logo.png" the image will be uploaded, saved and shown as "logo_my-site-logo.png"

Now I am sorry but why in the world you would do this? XC?
Images names matter. Do not change them like this.

The offensive file is - classes/XLite/Module/CDev/SimpleCMS/View/Model/Settings.php

PHP Code:

/**
     * Additional preparations for images.
     * Upload them into specific directory
     *
     * @param string $optionValue Option value
     * @param string $imageType   Image type
     *
     * @return string
     */
    
protected function prepareImageData($optionValue$imageType)
    {
        .............
            
$realName $imageType '_' $realName;

................... 


cflsystems 07-23-2017 10:39 AM

Re: SimpleCMS module - site logo
 
I think this should be a bug report


All times are GMT -8. The time now is 08:06 PM.

Powered by vBulletin Version 3.5.4
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.