X-Cart forums - Confirmed Bug - Customers Can't Pay partially with Gift Certificate

Page 2 of 3

Show 40 posts from this thread on one page

X-Cart forums (https://forum.x-cart.com/index.php)

- X-Payments issues & questions (https://forum.x-cart.com/forumdisplay.php?f=50)

- - Confirmed Bug - Customers Can't Pay partially with Gift Certificate (https://forum.x-cart.com/showthread.php?t=68326)

carpeperdiem

12-30-2013 06:19 AM

Re: Confirmed Bug - Customers Can't Pay partially with Gift Certificate

Quote:

Originally Posted by tartaglia

Thanks for the additional testing/confirmation carpeperdiem and cflsystems.

GOOD NEWS.... QT (Roman) has installed a patch for this issue on my store. It involved changes to the include/payment_method.php file (about 15 new lines of code)

After performing a single test (repeating the steps that reliably produced the problem on my site initially) I can say that it appears the problem is fixed.

If some of you with dev sites will get the patch and test it under your own circumstances and versions of XC it will increase my confidence that QT has put this issue to bed.

David,

Can you ask x-cart to share this patch with the community? Was this issue posted in bugtracker?

tartaglia

12-30-2013 11:24 AM

Re: Confirmed Bug - Customers Can't Pay partially with Gift Certificate

I can only assume it is in bug tracker (I did not file it there I filed it through my support subscription) I will ask the support engineer when he returns from holiday.

Also, it is my understanding that there is an external bug tracker (that users can file stuff in) and an internal bug tracker for QT maintenance staff. If this is the case it may only be in the internal one.

Have you tried asking QT for the patch for this issue? You may need to wait until after the holiday. If you still can't it then please post and let me know, I will be glad to post the 15 lines of code they added to the file.

David

Duramax 6.6L

12-31-2013 05:52 PM

Re: Confirmed Bug - Customers Can't Pay partially with Gift Certificate

Quote:

Originally Posted by tartaglia

Have you tried asking QT for the patch for this issue? You may need to wait until after the holiday. If you still can't it then please post and let me know, I will be glad to post the 15 lines of code they added to the file.

David

Would you please post the lines of code and where to place them to fix this problem.

BBM_	01-06-2014 08:05 PM

Re: Confirmed Bug - Customers Can't Pay partially with Gift Certificate

QT,

Please share the patch as I have found this issue as well and this is without using X-Payments.

ambal

01-08-2014 06:14 AM

Re: Confirmed Bug - Customers Can't Pay partially with Gift Certificate

Hi Everyone,

We are finalizing the patch to make it sort of "general" for everyone and will post it here as soon as it is ready. Please allow us several days.

tartaglia

01-08-2014 10:48 AM

Re: Confirmed Bug - Customers Can't Pay partially with Gift Certificate

Ambal - GREAT! thank you. I was just getting back to the forums after several days off, and was told that you would be making the patch generally available.

I'm sure many, many users need this they just didn't know it before.

Again much appreciated.

ambal

01-10-2014 12:52 AM

Re: Confirmed Bug - Customers Can't Pay partially with Gift Certificate

2 Attachment(s)

Here comes the patch.

Attachment 3657

Please note that if it does not work for your X-Cart installation it doesn't mean it is broken. Most likely it can not be applied to your X-Cart due to some customizations, difference in versions, etc and needs adjusting for your particular X-Cart version/copy. Also, many of you guys are not technical savvy so be careful about applying patches on open source software like X-Cart. Do not apply this patch if nothing is broken!!! Use it if you see the same trouble in your X-Cart shop and you really suffer from it.

Anyways, in case of a trouble with the patch you need to contact our techs regarding applying it for you (please be informed that a technical support incident fee may be required if you are not a customer with technical support service subscription).

cflsystems

01-10-2014 09:03 AM

Re: Confirmed Bug - Customers Can't Pay partially with Gift Certificate

Quote:

Originally Posted by ambal

Do not apply this patch if nothing is broken!!! Use it if you see the same trouble in your X-Cart shop and you really suffer from it.

Alex does this means the patch is for specific XC or server configuration? So is this a bug in XC or X-Payments or the Connector?
Are we to take this as workaround patch or as an official fix?

Also looking at the code

Code:

+    if (!empty($userinfo['id'])) {

+        $where = 'userid = "' . addslashes($userinfo['id']) .'"';

+    } elseif(!empty($userinfo['email'])) {

+        $where = 'email = "' . addslashes($userinfo['email']) .'"';

+    } else {

+        return;

+    }

Why addslashes($userinfo['id'])?

userid is integer, always, would be better to ensure it is integer instead of escaping characters. I think you should revise this.

ambal

01-13-2014 07:00 AM

Re: Confirmed Bug - Customers Can't Pay partially with Gift Certificate

It is a workaround patch/fix for X-Cart's X-Payments connector module. No need to change anything at X-Payment side.

My notes are more for forum members who are not really technical savvy and can make more harm than good by applying the patch. Especially when they do not realize they are using a customized X-Cart installation.

ambal

01-14-2014 02:57 AM

Re: Confirmed Bug - Customers Can't Pay partially with Gift Certificate

> Why addslashes($userinfo['id'])?

Thank you for noting this. I re-uploaded a new version of the patch that uses intval instead.

All times are GMT -8. The time now is 05:39 AM.

Page 2 of 3

Show 40 posts from this thread on one page