X-Cart forums - X-Cart 4.0.19 released

X-Cart forums (https://forum.x-cart.com/index.php)

- News and Announcements (https://forum.x-cart.com/forumdisplay.php?f=28)

- - X-Cart 4.0.19 released (https://forum.x-cart.com/showthread.php?t=24009)

X-Cart 4.0.19 released

Changelog for 4.0.19...please post any issues in this thread and hopefully X-Cart will address them.

Quote:

Tue Aug 08 11:59:27 MSD 2006 [!] - max - Bug: Partnes list was not displayed correctly on the Banners statistics page if a partner did not have a first name and a last name (as a result, the partner was represented by an empty line). Fixed.

Thu Aug 03 11:25:00 MSD 2006[*] - svowl - UPS Online Tools shipping module updated according to additional requirements of UPS: configuration section modified (some fields marked required; COD support, Oversize indicator added; design improved etc).

Tue Aug 01 13:46:02 MSD 2006 [!] - max - Bug: Product options were not displayed on the Returns page. Fixed.

Tue Aug 01 09:55:45 MSD 2006 [!] - max - Bug: Statistics on the Referred sales page were not displayed correctly if a customer placed an order with two instances of the same product with different product variant sets. Fixed.

Mon Jul 31 15:37:07 MSD 2006 [!] - max - Bug: A product could not be displayed on the Product details page if the product's main category was disabled for the current memebrship, but its additional category was enabled for the current membership. Fixed.

Mon Jul 31 14:36:04 MSD 2006[*] - max - Improvement: Instruction for Worlpay payment module added.

Mon Jul 31 14:14:09 MSD 2006 [!] - max - Bug: 'Log out' event got written to Login history statistics table with a wrong user type. Fixed.

Mon Jul 31 14:02:02 MSD 2006 [!] - max - Bug: Product subscription payments continued to be charged periodicly after the status of the subscription was set to 'Disabled'. Fixed.

Mon Jul 31 13:18:02 MSD 2006 [!] - max - Bug: Product options were not displayed correctly in the Order invoice if the order contained a product with deleted or disbled product options. Fixed.

Mon Jul 31 10:47:31 MSD 2006 [!] - max - Bug: ECHOnline payment module did not work correctly. Fixed.

Fri Jul 28 11:36:52 MSD 2006 [!] - max - Bug: Product cloning procedure did not work correctly if the store had products with productcodes from SKU1000 to SKU9999. Fixed.

Thu Jul 27 12:24:38 MSD 2006[*] - max - Improvement: USPS shipping module now supports HTTPS transactions.

Tue Jul 25 09:31:25 MSD 2006 [!] - max - Bug: BiBiT payment module displayed a wrong error message when transaction authorization failed. Fixed.

Mon Jul 24 12:10:12 MSD 2006 [!] - max - Bug: Special product prices were not displayed on Multicolumn products list pages. Fixed.

Mon Jul 24 09:36:42 MSD 2006 [!] - max - Bug: Customer bonuses were not deleted in the procedure of deleting a user profile. Fixed.

Mon Jul 24 09:25:59 MSD 2006 [!] - max - Bug: In Froogle module, a service word 'END' was added on the last line of the export file. Fixed.

Fri Jul 21 11:14:15 MSD 2006 [!] - max - Bug: A typo on the Orders list page. Fixed.

Fri Jul 21 09:28:11 MSD 2006 [!] - max - Bug: A typo in Froogle module. Fixed.

Wed Jul 19 12:10:37 MSD 2006[*] - max - Improvement: Space symbols are now deleted from column headers in the product import file.

Wed Jul 19 09:26:30 MSD 2006 [!] - max - Bug: ClearCommerce (PayFuse) payment module used port 443 for test transactions istead of 11500. Fixed.

Tue Jul 18 13:15:35 MSD 2006 [!] - max - Bug: Froogle module exported products from disabled categories. Fixed.

Mon Jul 17 10:58:27 MSD 2006 [!] - max - Bug: Billing country/state were not copied into shipping country/state fields if shipping country field was disabled. Fixed.

Mon Jul 17 09:14:00 MSD 2006 [!] - svowl - Bug: Discount value was displayed incorrectly in the cart totals if the option 'Display cart/order totals including tax' was enabled. Fixed.

Wed Jul 05 15:40:09 MSD 2006 [!] - max - Bug: HSBC payment module declined orders if the server returned 'The transaction was rejected by FraudShield' transaction status. Fixed.

Wed Jun 28 11:41:46 MSD 2006[*] - max - Improvement: Froogle module updated.

Mon Jun 26 10:51:17 MSD 2006[*] - max - Improvement: Product options data is now exported in updating mode.

Mon Jun 26 09:56:02 MSD 2006 [!] - max - Bug: Product importing procedure did not validate product options data. Fixed.

Fri Jun 23 11:57:28 MSD 2006[*] - max - Improvement: Quick Books export module can now export order payment transactions if the order status is 'Processed' or 'Completed'. Fixed.

Mon Jun 19 18:01:00 MSD 2006 [!] - svowl - Bug: The cart subtotal was displayed as an incorrect value if a configured product was added to the shopping cart. Fixed.

Fri Jun 16 13:24:49 MSD 2006 [!] - max - Bug: Card information was not validated in PayPal Pro payment module. Fixed.

Fri Jun 16 11:09:39 MSD 2006 [!] - max - Bug: The last step of checkout caused a JS error if the language variable 'txt_cc_number_invalid' contained quotes. Fixed.

Wed Jun 14 12:02:00 MSD 2006 [!] - svowl - Bug: Slot rules defined by 'AND' did not work on the customer side: products list was generated in a wrong way (X-Configurator). Fixed.

Mon Jun 05 15:08:00 MSD 2006 [!] - svowl - Bug: An empty dropdown box for quantity selection was displayed on the products list and product details pages if the minimum amount of a product was greater than the 'Maximum number of selections in quantity selectbox' option value and the option 'Disable inventory tracking' was enabled. Fixed.

Thu Jun 01 14:25:50 MSD 2006 [!] - max - Bug: Login procedure was non-case sensitive; as a result, a user could be logged in with a login name typed in a wrong case and not have access to some areas of the user interface and any data associated with the correct login name (like orders history). Fixed.

Thu Jun 01 14:03:04 MSD 2006[*] - max - Improvement: Support for 'site' transaction field added to SnS connector module. Fixed.

Thu May 25 15:13:14 MSD 2006 [!] - max - Bug: Smarty modifier 'escape' did not work on PHP versions below 4.1.0. Fixed.

Wed May 24 11:51:35 MSD 2006 [!] - max - Bug: A user was not redirected from HTTPS to HTTP after login procedure if the option 'Use secure login form on a separate page (HTTPS)' was enabled and the option 'Do not redirect customers from HTTPS to HTTP' was disabled. Fixed.

Mon May 22 16:35:01 MSD 2006 [!] - max - Bug: HTTPS requester mechanism did not return the first header of the response. Fixed.

Fri May 19 11:50:20 MSD 2006 [!] - max - Bug: Discount calculation did not work correctly if the cart contained a configurable product. Fixed.

Thu May 18 11:46:02 MSD 2006 [!] - max - Bug: GoEmerchant payment module caused a PHP error. Fixed.

Thu May 18 10:06:26 MSD 2006[*] - max - Improvement: 'Cannot read file: please check the read permissions' error message is added for the Edit templates page.

Thu May 18 09:35:21 MSD 2006 [!] - max - Bug: Download procedure did not work correctly (Egoods module). Fixed.

Thu May 18 09:17:19 MSD 2006 [!] - max - Bug: Bean Stream payment module did not work correctly with the server response. Fixed.

Tue May 16 11:01:42 MSD 2006 [!] - max - Bug: Affiliate plans did not get assigned to a partner if the partner login included 2 or more words. Fixed.

Fri May 12 09:39:39 MSD 2006 [!] - max - Bug: ViaKlix 2 payment method did not send the second line of the billing address. Fixed.

Thu May 11 14:51:46 MSD 2006 [!] - max - Bug: The installation script could not correctly install an alternative skin if the user also selected a non-default color scheme. Fixed.

Thu May 11 10:46:31 MSD 2006[*] - max - Improvement in Antifraud module: a new field set is now supported.

Wed May 10 09:56:49 MSD 2006 [!] - max - Bug: Saferpay payment module did not work correctly on Windows web servers. Fixed.

Sat May 06 15:37:43 MSD 2006[*] - max - Improvement: category data is now sent to SnS collector (AdvancedSearch action) as a category path instead of a category name (SnS connector module). Fixed.

Sat May 06 15:10:44 MSD 2006 [!] - max - Bug: In SnS connector module, certain types of data were sent incorrectly to SnS collector (If customer reviews and information for the 'Contact us' form contained quotes, they were passed to SnS collector preceded by slashes. Register action was sent even when a user account was created by the store admin, although it was only supposed to happen if a customer registered an account personally). Fixed.

Fri May 05 17:52:38 MSD 2006 [!] - max - Bug: User name was not displayed correctly on the last step of Checkout page in 'Cardholder name' and 'Ship to' fields. Fixed.

Fri May 05 17:39:36 MSD 2006 [!] - max - Bug: Check requirements mechanism did not check the PCRE extension status. Fixed.

Fri May 05 14:00:08 MSD 2006 [!] - max - Bug: PayPal Express Checkout was working although the option 'Disable anonymous checkout' was enabled. Fixed.

Thu May 04 17:52:39 MSD 2006 [!] - max - Bug: Customer name was not displayed correctly on the Product details page (Customer feedback section) if the customer first name or last name contained a quote. Fixed.

Thu May 04 17:25:20 MSD 2006 [!] - max - Bug: Customer data is displayed incorrectly on the Order page. Fixed.

Thu May 04 16:35:07 MSD 2006 [!] - max - Bug: Discount coupon expiration date was set without a time zone offset. Fixed.

Thu May 04 11:52:00 MSD 2006[*] - svowl - The form for tracking USPS delivery updated (Order Tracking module).

Tue May 02 13:58:54 MSD 2006 [!] - max - Bug: Import procedure did not report about an import error if a provider was importing a CSV file with an empty category column and all the categories in the store were deleted. Fixed.

Tue May 02 11:42:41 MSD 2006 [!] - max - Bug: Extra field values and the selected manufacturer were not saved on the Product modify page. Fixed.

Sat Apr 29 14:43:04 MSD 2006 [!] - max - Bug: A new event was displyed with added slashes (event title, description and HTML-content) (Gift Registry module). Fixed.

Wed Apr 26 16:28:00 MSD 2006 [!] - svowl - Bug: If the option 'Display cart/order totals including tax' was enabled, the option 'Display product price including tax' was disabled, and tax was applied to subtotal + shipping, then the line 'Coupon discount', which was not expected to appear, appeared in the cart totals. Fixed.

Mon Apr 24 16:37:00 MSD 2006 [!] - svowl - Bug: In X-SpecialOffers, if the total discount amount exceeded the maximum allowed amount, the discount was not applied. Fixed (Now the maximum allowed amount of the discount is applied).

Mon Apr 24 14:59:00 MSD 2006 [!] - svowl - Bug: UPS shipping methods that were not allowed for the store origin location were displayed in the dropdown box in the cart when the option 'Enable all shipping methods even if a customer is not logged in' was enabled and the module 'UPS OnLine Tools' was turned on. Fixed.

Mon Apr 24 09:36:54 MSD 2006 [!] - max - Bug: The counter of deleted products was working wrongly in PRO mode. Fixed.

Sat Apr 22 11:06:31 MSD 2006 [!] - max - Bug: X-Special offers module installation script did not copy e-mail message templates. Fixed.

Fri Apr 21 13:42:23 MSD 2006 [!] - max - Bug: The product was not created in 2Checkout.com payment module if it had an empty description. Fixed.

Thu Apr 20 16:09:29 MSD 2006 [!] - max - Bug: WorlPay Payment module did not work correctly on the last step of the payment transaction. Fixed.

Thu Apr 20 12:17:18 MSD 2006 [!] - max - Bug: Redirect from HTTP to HTTPS part did not work correctly if all the shop pages were located on the HTTPS side and home.php in Customer area was entered as DirectoryIndex in .htaccess file. Fixed.

Thu Apr 13 15:10:32 MSD 2006 [!] - max - Bug: Edit product options page had a link to hidden Product option exceptions section if a provider was editing a group of products. Fixed.

Wed Apr 12 10:30:40 MSD 2006 [!] - max - Bug: Product option exceptions did not work correctly if the product had a text product option. Fixed.

Thu Apr 06 16:05:27 MSD 2006 [!] - max - Bug: Froogle export file did not have 'END' word in the end of file. Fixed.

Thu Apr 06 15:23:25 MSD 2006 [!] - max - Bug: In X-AOM, the available quantity of a product was defined wrongly if the product options selected during the editing of the order by admin differed from the options with which the product was initially ordered. Fixed.

Thu Apr 06 11:33:00 MSD 2005 [!] - svowl - Bug: When an offer of a certain provider was applied to the cart and the customer went to check bonus products by clicking 'Check for special offers', he could see a list of products that included products not only of that provider (X-SpecialOffers). Fixed.

Wed Apr 05 16:23:00 MSD 2005 [-] - svowl - Way2Pay payment module removed as this payment processor is no longer supported.

Wed Apr 05 15:17:00 MSD 2005[*] - svowl - Improvement: Ability to include hidden products into a bonus added (X-SpecialOffers).

Tue Apr 04 17:25:00 MSD 2005[*] - svowl - Improvement in the security of Subscriptions module.

Tue Apr 04 16:17:00 MSD 2006 [!] - svowl - Bug: GnuPG/PGP encryption routine didnot encode the message because of a typo in the func_pgp_encrypt() function. Fixed.

Tue Apr 04 14:59:00 MSD 2006 [!] - svowl - Bug: A free product was added to the cart as a non-free product if the offer condition included products from some category and the bonus product was from the same category (X-SpecialOffers). Fixed.

Tue Apr 04 11:06:00 MSD 2006[*] - svowl - The links to PayPal Pro Notes from the PayPal settings page modified.

Mon Apr 03 17:58:00 MSD 2006 [!] - svowl - Bug: It was impossible to switch the 'Triple Deal' payment module from test to live mode. Fixed.

Thu Mar 30 10:48:27 MSD 2006 [!] - max - Bug: X-AOM module was allowed to edit an ESD product's quantity. Fixed.

Wed Mar 29 15:11:32 MSD 2006 [!] - max - Bug: Images moving procedure did not work corectly if the images path was specified with a space symbol after or before the path. Fixed.

Tue Mar 28 16:47:20 MSD 2006 [!] - max - Bug: Deletion of a cart item caused an error if the customer clicked the 'Clear cart' button in one browser window and the 'Delete item' button in another browser window. Fixed.

Mon Mar 27 09:42:53 MSD 2006 [!] - max - Bug: Return amount was not displayed correctly on the Returns page and in EMail notifications (order item amount was displayed instead of the return amount). Fixed.

Sat Mar 25 12:33:00 MSK 2006 [!] - max - Bug: The amount of a discount coupon was calculated wrongly if the cart contained a configurable product. Fixed.

Sat Mar 25 11:37:24 MSK 2006 [!] - max - Bug: Payment gateway return happened too shortly before payment gateway callback request (nearly simultaneously), for example, in PayPal IPN payment method. As a result, the order got the status Queued in spite of the fact that it was processed by the gateway. Fixed.

Fri Mar 24 16:59:06 MSK 2006 [!] - max - Bug: Taxes were displayed on the Order details page and Order invoice page as included into the product price, but the fact was not stated. Fixed.

Fri Mar 24 11:06:15 MSK 2006 [!] - max - Bug: Blowfish encryption method did not work correctly on PHP 4.4.1, 5.0.2 and 4.0.6. Fixed.

Fri Mar 24 10:18:50 MSK 2006 [!] - max - Bug: Subcategory counters were not recalculated after product import procedure. Fixed.

Thu Mar 23 14:17:59 MSK 2006 [!] - max - Bug: Product quantity was displayed as empty on the Product details page if the default variant had an empty quantity. Fixed.

Thu Mar 23 11:31:31 MSK 2006 [!] - max - Bug: The 'Back' button did not work correctly in the Product search section (after the user went to view any page of the search results other than the first one, clicking the 'Back' button never brought him or her back to the first page). Fixed.

Thu Mar 23 09:37:58 MSK 2006 [!] - max - Bug: Extra line breaks appeared in the category desription (Customer area) if the description contained HTML tags. Fixed.

Thu Mar 23 09:18:38 MSK 2006[*] - max - Improvement: USPS shipping method updated (Domectic rate calculator API 2.0 support added).

Mon Mar 20 11:46:22 MSK 2006 [!] - max - Bug: Product price was not defined on the Product details page if the product had variants and all the variant prices were empty. Fixed.

Mon Mar 20 09:44:16 MSK 2006 [!] - max - Bug: X-Cart tried to access SnS collector service script even if the option field 'Path to Sales-n-Stats collector' was empty. Fixed.

Sat Mar 18 14:12:14 MSK 2006 [!] - max - Bug: Product thumbnails and detailed images were not deleted from the file system in the procedure of deleting a product. Fixed.

Thu Mar 16 11:50:00 MSK 2006 [!] - svowl - Bug: Tax rates were calculated without taking into account, which tax rate was created by which provider (X-Cart PRO). Fixed.

Wed Mar 15 17:34:30 MSK 2006 [!] - max - Bug: PayPal Web Payments Pro payment module did not send Shipping address information. Fixed.

Wed Mar 15 14:34:03 MSK 2006 [!] - max - Bug: Changing the value of the Tax exempt field (Product modify page) caused a JS-error in FireFox browser. Fixed.

Wed Mar 15 11:59:55 MSK 2006 [!] - max - Bug: Any product was added with the quantity of just one item if Subscription module was enabled. Fixed.

Wed Mar 15 11:38:28 MSK 2006 [!] - max - Bug: If all the products in the store that belonged to a certain product class did not have product class option values, and some of these products were added to a comparison chart, displaying the Product features chart page caused a PHP error when these products were deleted from the chart. Fixed.

Wed Mar 15 10:05:04 MSK 2006 [!] - max - Bug: Input parameters were not validated on the Cart page ('Add to cart' procedure). Fixed.

Sat Mar 11 12:34:39 MSK 2006 [!] - max - Bug: Orders info ('Since the last log in' part) was calculated wrongly on the Summary page. Fixed.

Thu Mar 09 10:12:14 MSK 2006 [!] - max - Bug: Product classifications export did not function correctly if product key was equal to product code (SKU). Fixed.

Mon Mar 06 12:19:33 MSK 2006 [!] - max - Bug: Shopping cart conversion funnel statistics wasn't collected correctly if a customer modified his or her profile using the 'Modify' link on the last step of checkout. Fixed.

Fri Mar 03 14:40:02 MSK 2006 [!] - max - Bug: Products' tax rates were displayed on the Product search results page in Partner area. Fixed.

Thanks for the update and fixes...

My initial reaction:

S-L-O-W

Everything feels slower. Significantly. I upgraded from 4.0.18

I do NOT have fancy categories.
Advanced Stats are disabled.

My site in .18 is relatively fast -- but it tends to lose its punch in .19

is it just me?

Thanks,

Jeremy

New installation of v4.0.19 felt pretty fast (with whatever default settings), I couldn't notice anything in particular. By slow, what did you mean?

Still going through the process of updating files that couldn't be updated.

EDIT: How are you quantifying the difference in speed? The new installation with one skin loaded up pretty much instantly for me. Maybe clear templates_c?

EDIT: woohoo, got one of my wishes granted by X-Cart, they upgraded USPS to V2 :D

Not to double post or anything but this deserves it's own post.

I was wondering about the order in which I should apply the patch.

Currently I use one of the X-Cart's skin and now the upgrade kit, the new, and old skin installation define products.tpl.

I took me like the past half-hour or so to figure that out because ... it's been a long day. So now that I'm not caught in that loop, I was wondering what I should do? What I've done so far was just extrac that upgrade kit and applied it. I was in the process of manually upgrading the files until that particular problem popped up and stumped me. So should I just ignore it and apply the new skin or what should I do?

For a few months now I have thought that the 4.0.x branch was no longer going to see further point upgrades. Surprise surprise!! :D :D

Thanks X-Cart team!!

Lots of things in this one.

Upgrade from 018 to 019
Now not work Search statistics.

Quote:

Originally Posted by carpeperdiem

I haven't played with 4.0.19 yet but I have given the code changes a look over. I can't see anything that would make all the pages be slower. But there is a change that will probably make the product pages slower if you use product options. They added a call to func_get_default_options in customer_options.php. Its inside an if but the variable tested looks like its never set so it will always make the call and tests on 4.0.18 confirm its not set. func_get_default options does a lot of processing including several queries. I imagine it will slow things down some. I can't correlate this change to anything on the release change list. I'd say if you're happy with how 4.0.18 displays options try commenting out the new code in customer_options.php and see if you get back to 4.0.18 speed.

Quote:

Originally Posted by geckoday

Quote:

Originally Posted by carpeperdiem

Thanks for the insight and the tip Ralph!!

Quote:

Originally Posted by geckoday

there is a change that will probably make the product pages slower if you use product options. They added a call to func_get_default_options in customer_options.php. Its inside an if but the variable tested looks like its never set so it will always make the call and tests on 4.0.18 confirm its not set. func_get_default options does a lot of processing including several queries. I imagine it will slow things down some.

Wow, Ralph -- that is some find there!

I just happen to be moving to a new server, and I am benchmarking all kinds of things -- true apples for apples testing... and I am testing virgin installs now -- I have put my store on the shelf until I sort some core stuff out...

Commenting out the "upgraded" 4.0.19 code in /modules/Product_Options/customer_options.php makes a HUGE difference in page load times for pages with options or variants. HUGE. Dramatic difference. Wow.

This is how the code looks in 4.0.18:

Code:

$product_options = func_get_product_classes($productid);

This is what it looks like in 4.0.19:

Code:

$product_options = func_get_product_classes($productid);

if (empty($options)) {

        $min_amount = $product_info['min_amount'] ? $product_info['min_amount'] : 1;

        $options = func_get_default_options($productid, $min_amount, $user_account['membership']);

}

So, to the PHP experts: what exactly is this function doing?

Code:

if (empty($options)) {

        $min_amount = $product_info['min_amount'] ? $product_info['min_amount'] : 1;

        $options = func_get_default_options($productid, $min_amount, $user_account['membership']);

}

Is it looking for a situation where there is no option selected, and then setting a default option? I went through the changelog for .19 and there are a few references to "product options" -- but I think this code is the long way around to solve a very special problem... please correct me if I'm wrong...

Quote:

Wed Mar 15 11:38:28 MSK 2006 [!] - max - Bug: If all the products in the store that belonged to a certain product class did not have product class option values, and some of these products were added to a comparison chart, displaying the Product features chart page caused a PHP error when these products were deleted from the chart. Fixed.

Seems like for my store, where all but a few items have product options, and all of the options are single color variants as pull-down menus, this code is just a drag for me -- Ralph, does this sound right to you? Other PHP experts?

I wonder how many sub-routines there are that are the long way around, simply to solve a rare problem, but for 99% of the users, there is no need to do this... and B-L-O-A-T starts creeping in... and the codebase needs a rewrite -- oh, they did this in 4.1

Man, how I wish 4.1 was ready for prime time. I am using too many cool mods though... so 4.0.x is going to be it for the time being...

I have commented out this code from .19 -- if someone can think of a reason why I might want to keep it live, PLEASE, PLEASE speak up.

Thanks Ralph!!!!

Jeremy

Quote:

Originally Posted by carpeperdiem

Code:

$product_options = func_get_product_classes($productid);

This is what it looks like in 4.0.19:

Code:

$product_options = func_get_product_classes($productid);

if (empty($options)) {

        $min_amount = $product_info['min_amount'] ? $product_info['min_amount'] : 1;

        $options = func_get_default_options($productid, $min_amount, $user_account['membership']);

}

So, to the PHP experts: what exactly is this function doing?

Code:

if (empty($options)) {

        $min_amount = $product_info['min_amount'] ? $product_info['min_amount'] : 1;

        $options = func_get_default_options($productid, $min_amount, $user_account['membership']);

}

Is it looking for a situation where there is no option selected, and then setting a default option?

Well, customer_options is included into product.php which is what displays the product page in the first place so no options are ever selected. For the life of me I haven't been able to find anything that would ever set that variable before this code is executed. All I can guess is that maybe that variable is used by a module I don't have to set the option to be preselected when the page is displayed. I haven't been able to wrap my mind around func_get_default_options yet and what its all about. It used by cart.php and wishlist too I believe. Exactly what for I don't know yet.

Quote:

I went through the changelog for .19 and there are a few references to "product options" -- but I think this code is the long way around to solve a very special problem... please correct me if I'm wrong...

Quote:

Hard to say. I'm guessing not.

Quote:

I wonder how many sub-routines there are that are the long way around, simply to solve a rare problem, but for 99% of the users, there is no need to do this... and B-L-O-A-T starts creeping in... and the codebase needs a rewrite -- oh, they did this in 4.1

There are lots of places with bloat. The whole product/variant world screams for a much better object-oriented approach where virtually the same queries don't get reexecuted several times when displaying a page. I'm not sure how much optimization was done in 4.1.

Quote:

Man, how I wish 4.1 was ready for prime time. I am using too many cool mods though... so 4.0.x is going to be it for the time being...

I have commented out this code from .19 -- if someone can think of a reason why I might want to keep it live, PLEASE, PLEASE speak up.

Thanks Ralph!!!!

Jeremy

Thanks for sharing your experience Jeremy. I would have blindly installed 4.0.19 and never seen the performance issue in testing and probably not until my holiday peak season when it could cost me a lot of money.

You know what else this little bit of code does? It inverts the order of your product option variants... for example, if you had a list, such as:

Light
Light Medium
Medium
Medium Dark
Dark

With the new code, your product variants list as:

Dark
Medium Dark
Medium
Light Medium
Light

If I comment out the new and improved code, the order of variants is restored.

Now that's simply absurd... variants should display in the order listed -- I have commented out the code and I am testing. So far, so good. I'll test more tomorrow. Bed time.

Quote:

Originally Posted by carpeperdiem

You know what else this little bit of code does? It inverts the order of your product option variants...

Ho ho ho. I was wondering whether any of that wierdness in func_get_default_options would spill over into the actual display. Betcha if different variants have different prices the lowest price ones will display first.

OK, found where $options get set. Its when displaying the popup to edit the options in the cart or the wishlist. Makes sense for preselecting the current options for the item in the cart or wishlist. But I still can't figure out what func_get_default_options is all about. It looks like it will get called before adding a product to the cart or the wishlist. But its another of those where it depends on something not being set and I can't find out where it would ever be set.

I beleive there is an error in one of the diffs

include/file_operations.php

diff is looking for

Code:

$top_message["content"] = func_get_langvar_by_name("msg_err_file_wrong");

                 $top_message["type"] = "E";

                 func_header_location($action_script.(!empty($dir) ? "?dir=$dir".$opener_str_end : $opener_str_begin));

...

in reality

Code:

                 $top_message["content"] = func_get_langvar_by_name("msg_err_file_wrong");

                 $top_message["type"] = "E";

...

Quote:

Originally Posted by alru111

I beleive there is an error in one of the diffs

include/file_operations.php

diff is looking for

Code:

$top_message["content"] = func_get_langvar_by_name("msg_err_file_wrong");

                 $top_message["type"] = "E";

                 func_header_location($action_script.(!empty($dir) ? "?dir=$dir".$opener_str_end : $opener_str_begin));

...

in reality

Code:

                 $top_message["content"] = func_get_langvar_by_name("msg_err_file_wrong");

                 $top_message["type"] = "E";

...

I think you're looking at the wrong location in the file. The diff refers to line 495 which looks just fine. You may be looking at line 461.

after update when looking at individual user info (search for users from admin panel) I have referrer disappeared and screen somewhat corrupted.

Does anyone have that too?

One more thing - I get an sql error when searching for product by sku and by search word (at the same time) from admin panel.

Code:

INVALID SQL: 0 :

SQL QUERY FAILURE: SELECT COUNT(*), MIN(xcart_pricing.price) as price , xcart_products_lng.product as product_lng, xcart_products_lng.descr as descr_lng, xcart_products_lng.full_descr as fulldescr_lng FROM xcart_products, xcart_pricing , xcart_categories, xcart_products_categories LEFT JOIN xcart_products_lng ON xcart_products_lng.productid = xcart_products.productid AND xcart_products_lng.code = 'US' WHERE xcart_pricing.productid=xcart_products.productid AND xcart_pricing.quantity=1 AND (xcart_pricing.membership='' OR xcart_pricing.membership='') AND xcart_pricing.variantid = 0 AND MATCH (xcart_products.product) AGAINST ('SEARCH_STRING') AND xcart_products_categories.productid=xcart_products.productid AND xcart_products_categories.categoryid = xcart_categories.categoryid AND (xcart_products.productcode LIKE '%SEARCH_SKU%' OR xcart_products.productid IN ()) AND xcart_products.forsale='Y' GROUP BY xcart_products.productid

Don't know if it's cause of 4.19 update, but I didn't notice it before.
Anyone have it?

There is an issue regarding where X-Cart re-directs you. If say you are logged into the admin's side under one of the sections that's in the provider directory (Products and Inventory). Then you log in on the customer's side (say to test a feature). Then you get logged out of admin's side (I know that is suppose to happen) and the login form you get redirected to is for Providers so if you type in your admin password, you can't login.

This issue exists in both v4.0.18 and v4.0.19.